Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6050)

Unified Diff: chrome/test/ui/ui_test.cc

Issue 10895: Add Terminate() to the Process object, have RenderProcessHost use this to avo... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/ui/run_all_unittests.cc ('k') | chrome/tools/convert_dict/convert_dict.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/ui/ui_test.cc
===================================================================
--- chrome/test/ui/ui_test.cc (revision 5371)
+++ chrome/test/ui/ui_test.cc (working copy)
@@ -239,12 +239,11 @@
browser_launch_time_ = TimeTicks::Now();
- bool started = process_util::LaunchApp(
- command_line,
- false, // Don't wait for process object (doesn't work for
- // us)
- !show_window_,
- &process_);
+ bool started = base::LaunchApp(command_line,
+ false, // Don't wait for process object
+ // (doesn't work for us)
+ !show_window_,
+ &process_);
ASSERT_EQ(started, true);
if (use_existing_browser_) {
@@ -253,7 +252,7 @@
user_data_dir_.c_str());
GetWindowThreadProcessId(hwnd, &pid);
// This mode doesn't work if we wound up launching a new browser ourselves.
- ASSERT_NE(pid, process_util::GetProcId(process_));
+ ASSERT_NE(pid, base::GetProcId(process_));
CloseHandle(process_);
process_ = OpenProcess(SYNCHRONIZE, false, pid);
}
@@ -317,9 +316,9 @@
// Make sure that no instances of the browser remain.
const int kExitTimeoutMs = 5000;
const int kExitCode = 1;
- process_util::CleanupProcesses(
- chrome::kBrowserProcessExecutableName, kExitTimeoutMs, kExitCode,
- &filter);
+ base::CleanupProcesses(
+ chrome::kBrowserProcessExecutableName, kExitTimeoutMs, kExitCode,
+ &filter);
// Suppress spammy failures that seem to be occurring when running
// the UI tests in single-process mode.
@@ -442,8 +441,8 @@
/*static*/
int UITest::GetBrowserProcessCount() {
BrowserProcessFilter filter(L"");
- return process_util::GetProcessCount(chrome::kBrowserProcessExecutableName,
- &filter);
+ return base::GetProcessCount(chrome::kBrowserProcessExecutableName,
+ &filter);
}
static DictionaryValue* LoadDictionaryValueFromPath(const std::wstring& path) {
« no previous file with comments | « chrome/test/ui/run_all_unittests.cc ('k') | chrome/tools/convert_dict/convert_dict.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698