remoting/client/plugin/pepper_input_handler.cc - Issue 10894050: Remove support for Windows-style keycodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/plugin/pepper_input_handler.cc

Issue 10894050: Remove support for Windows-style keycodes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: DCHECK in EventExecutors if the USB keycode is missing Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/client/plugin/pepper_input_handler.cc

diff --git a/remoting/client/plugin/pepper_input_handler.cc b/remoting/client/plugin/pepper_input_handler.cc

index ca49ffd4cc0cb0b4db6b34fda96a74e77094b4f3..208bfa056b8c9e63c52bdb3804f856b02dead06d 100644

--- a/remoting/client/plugin/pepper_input_handler.cc

+++ b/remoting/client/plugin/pepper_input_handler.cc

@@ -44,10 +44,7 @@ bool PepperInputHandler::HandleInputEvent(const pp::InputEvent& event) {

case PP_INPUTEVENT_TYPE_KEYUP: {

pp::KeyboardInputEvent pp_key_event(event);

protocol::KeyEvent key_event;

- key_event.set_keycode(pp_key_event.GetKeyCode());

- uint32 keycode = GetUsbKeyCode(pp_key_event);

- if (keycode != 0)

- key_event.set_usb_keycode(keycode);

+ key_event.set_usb_keycode(GetUsbKeyCode(pp_key_event));

key_event.set_pressed(event.GetType() == PP_INPUTEVENT_TYPE_KEYDOWN);

input_stub_->InjectKeyEvent(key_event);

return true;