remoting/client/plugin/chromoting_instance.cc - Issue 10894050: Remove support for Windows-style keycodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/plugin/chromoting_instance.cc

Issue 10894050: Remove support for Windows-style keycodes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: DCHECK in EventExecutors if the USB keycode is missing Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/client/plugin/chromoting_instance.cc

diff --git a/remoting/client/plugin/chromoting_instance.cc b/remoting/client/plugin/chromoting_instance.cc

index a28a8e96accea75493e4138af0549e0972d8f536..9038b4f0f1dc255e276fd3c72341e35e49c5c9f7 100644

--- a/remoting/client/plugin/chromoting_instance.cc

+++ b/remoting/client/plugin/chromoting_instance.cc

@@ -299,8 +299,6 @@ void ChromotingInstance::HandleMessage(const pp::Var& message) {

protocol::KeyEvent event;

event.set_usb_keycode(usb_keycode);

event.set_pressed(is_pressed);

- // Even though new hosts will ignore keycode, it's a required field.

- event.set_keycode(0);

InjectKeyEvent(event);

} else if (method == "remapKey") {

int from_keycode = 0;