Clear the favicon of a tab when navigating to a url on a different host.

chrome/browser/favicon/favicon_tab_helper.cc

Index: chrome/browser/favicon/favicon_tab_helper.cc
===================================================================
--- chrome/browser/favicon/favicon_tab_helper.cc	(revision 153636)
+++ chrome/browser/favicon/favicon_tab_helper.cc	(working copy)
@@ -176,6 +176,13 @@
 void FaviconTabHelper::DidNavigateMainFrame(
     const content::LoadCommittedDetails& details,
     const content::FrameNavigateParams& params) {
+
+  // When navigating to a different host, clear the favicon.
+  if (details.previous_url.host() != details.entry->GetURL().host()) {

[pkotwicz, 2012/09/29 23:54:38]

The favicon should actually always be cleared. (You can remove the if
statement).
I commented on the bug as to why I believe this should be the case. Sorry for
the delay

+    FaviconStatus default_favicon;
+    details.entry->GetFavicon() = default_favicon;

[msw, 2012/09/21 21:46:54]

nit: I think you can just do details.entry->GetFavicon() = FaviconStatus(); in
one line and drop the braces.

+  }
+
   // Get the favicon, either from history or request it from the net.
   FetchFavicon(details.entry->GetURL());
 }