Clear the favicon of a tab when navigating to a url on a different host.

chrome/browser/favicon/favicon_tab_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/favicon/favicon_tab_helper.h"
 
 #include "chrome/browser/favicon/favicon_handler.h"
 #include "chrome/browser/favicon/favicon_service_factory.h"
 #include "chrome/browser/favicon/favicon_util.h"
 #include "chrome/browser/favicon/select_favicon_frames.h"
@@ skipping 158 matching lines @@
     FaviconService* favicon_service = FaviconServiceFactory::GetForProfile(
         profile_, Profile::IMPLICIT_ACCESS);
     if (favicon_service)
       favicon_service->SetFaviconOutOfDateForPage(url);
   }
 }
 
 void FaviconTabHelper::DidNavigateMainFrame(
     const content::LoadCommittedDetails& details,
     const content::FrameNavigateParams& params) {
+
+  // When navigating to a different host, clear the favicon.
+  if (details.previous_url.host() != details.entry->GetURL().host()) {

[pkotwicz, 2012/09/29 23:54:38]

The favicon should actually always be cleared. (You can remove the if
statement).
I commented on the bug as to why I believe this should be the case. Sorry for
the delay

+    FaviconStatus default_favicon;
+    details.entry->GetFavicon() = default_favicon;

[msw, 2012/09/21 21:46:54]

nit: I think you can just do details.entry->GetFavicon() = FaviconStatus(); in
one line and drop the braces.

+  }
+
   // Get the favicon, either from history or request it from the net.
   FetchFavicon(details.entry->GetURL());
 }
 
 bool FaviconTabHelper::OnMessageReceived(const IPC::Message& message) {
   bool message_handled = false;   // Allow other handlers to receive these.
   IPC_BEGIN_MESSAGE_MAP(FaviconTabHelper, message)
     IPC_MESSAGE_HANDLER(IconHostMsg_DidDownloadFavicon, OnDidDownloadFavicon)
     IPC_MESSAGE_HANDLER(IconHostMsg_UpdateFaviconURL, OnUpdateFaviconURL)
     IPC_MESSAGE_UNHANDLED(message_handled = false)
@@ skipping 14 matching lines @@
   scale_factors = ui::GetSupportedScaleFactors();
   gfx::Image favicon(SelectFaviconFrames(
       bitmaps, scale_factors, requested_size, &score));
   favicon_handler_->OnDidDownloadFavicon(
       id, image_url, errored, favicon, score);
   if (touch_icon_handler_.get()) {
     touch_icon_handler_->OnDidDownloadFavicon(
         id, image_url, errored, favicon, score);
   }
 }