Metro mode switching (chrome side)

Metro mode switching (chrome side)

This change puts a menu option to restart chrome in desktop or
to restart chrome in metro mode and then wires up to the restart
helper.


BUG=141032
TEST=see bug
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155263

[cpu_(ooo_6.6-7.5), 2012-09-05 01:15:49]

the chrome side.

[grt (UTC plus 2), 2012-09-05 01:40:51]

please fix the whitespace errors pointed out by lint, too.

http://codereview.chromium.org/10885047/diff/11001/chrome/app/generated_resou...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/10885047/diff/11001/chrome/app/generated_resou...
chrome/app/generated_resources.grd:17398: +      Restart in Desktop mode
"Restart on the desktop" is consistent with IE's text.

http://codereview.chromium.org/10885047/diff/11001/chrome/app/generated_resou...
chrome/app/generated_resources.grd:17402: +      Restart in Immersive mode
Does "Immersive" mean anything to the world at large?  Does this word appear in
Windows' UI?

http://codereview.chromium.org/10885047/diff/11001/chrome/browser/browser_shu...
File chrome/browser/browser_shutdown.cc (right):

http://codereview.chromium.org/10885047/diff/11001/chrome/browser/browser_shu...
chrome/browser/browser_shutdown.cc:160:
prefs->SetBoolean(prefs::kRestartSwitchMode, false);
either de-indent this line, or put braces around the 159 - 160 block

http://codereview.chromium.org/10885047/diff/11001/chrome/browser/first_run/u...
File chrome/browser/first_run/upgrade_util_win.cc (left):

http://codereview.chromium.org/10885047/diff/11001/chrome/browser/first_run/u...
chrome/browser/first_run/upgrade_util_win.cc:85: 
this was my favorite blank line in all of chrome.

http://codereview.chromium.org/10885047/diff/11001/chrome/browser/first_run/u...
File chrome/browser/first_run/upgrade_util_win.cc (right):

http://codereview.chromium.org/10885047/diff/11001/chrome/browser/first_run/u...
chrome/browser/first_run/upgrade_util_win.cc:98: // Pass this Chrome's Start
Menu shortcut path and handle to the relauncher.
please update comment since a handle is no longer passed

http://codereview.chromium.org/10885047/diff/11001/chrome/browser/first_run/u...
chrome/browser/first_run/upgrade_util_win.cc:108: // handle inheritance so the
relauncher can wait for our exit. So we create a
suggest changing " so the relauncher can wait for our exit. So we" -> ". Since
we can't pass a handle to the relaucher, we"

[cpu_(ooo_6.6-7.5), 2012-09-05 22:20:07]

http://codereview.chromium.org/10885047/diff/11001/chrome/app/generated_resou...
File chrome/app/generated_resources.grd (left):

http://codereview.chromium.org/10885047/diff/11001/chrome/app/generated_resou...
chrome/app/generated_resources.grd:17398: <message
name="IDS_MEDIA_GALLERIES_DIALOG_HEADER" desc="Header for media gallery
permissions dialog.">
see email for the text. I'll change to what is there.

http://codereview.chromium.org/10885047/diff/11001/chrome/browser/browser_shu...
File chrome/browser/browser_shutdown.cc (right):

http://codereview.chromium.org/10885047/diff/11001/chrome/browser/browser_shu...
chrome/browser/browser_shutdown.cc:160:
prefs->SetBoolean(prefs::kRestartSwitchMode, false);
Good catch.

On 2012/09/05 01:40:51, grt wrote:
> either de-indent this line, or put braces around the 159 - 160 block

http://codereview.chromium.org/10885047/diff/11001/chrome/browser/first_run/u...
File chrome/browser/first_run/upgrade_util_win.cc (left):

http://codereview.chromium.org/10885047/diff/11001/chrome/browser/first_run/u...
chrome/browser/first_run/upgrade_util_win.cc:85: 
My bad! done.

On 2012/09/05 01:40:51, grt wrote:
> this was my favorite blank line in all of chrome.

http://codereview.chromium.org/10885047/diff/11001/chrome/browser/first_run/u...
File chrome/browser/first_run/upgrade_util_win.cc (right):

http://codereview.chromium.org/10885047/diff/11001/chrome/browser/first_run/u...
chrome/browser/first_run/upgrade_util_win.cc:98: // Pass this Chrome's Start
Menu shortcut path and handle to the relauncher.
On 2012/09/05 01:40:51, grt wrote:
> please update comment since a handle is no longer passed

Done.

http://codereview.chromium.org/10885047/diff/11001/chrome/browser/first_run/u...
chrome/browser/first_run/upgrade_util_win.cc:108: // handle inheritance so the
relauncher can wait for our exit. So we create a
On 2012/09/05 01:40:51, grt wrote:
> suggest changing " so the relauncher can wait for our exit. So we" -> ". Since
> we can't pass a handle to the relaucher, we"

Done.

[cpu_(ooo_6.6-7.5), 2012-09-05 22:20:23]

please take a look again.

[cpu_(ooo_6.6-7.5), 2012-09-06 17:47:41]

Scott, can you review the /ui/ bits?

[grt (UTC plus 2), 2012-09-06 18:29:05]

lgtm

[ananta, 2012-09-06 18:36:42]

LGTM with nits

http://codereview.chromium.org/10885047/diff/11005/chrome/browser/ui/browser_...
File chrome/browser/ui/browser_command_controller.cc (right):

http://codereview.chromium.org/10885047/diff/11005/chrome/browser/ui/browser_...
chrome/browser/ui/browser_command_controller.cc:355: RestartWithModeSwitch();
Unify the two cases

http://codereview.chromium.org/10885047/diff/11005/chrome/browser/ui/toolbar/...
File chrome/browser/ui/toolbar/wrench_menu_model.cc (right):

http://codereview.chromium.org/10885047/diff/11005/chrome/browser/ui/toolbar/...
chrome/browser/ui/toolbar/wrench_menu_model.cc:470: if (base::win::GetVersion()
> base::win::VERSION_WIN7) {
We can safely remove the version check here given that we already call
IsMetroProcess

[sky, 2012-09-06 20:29:24]

LGTM