remoting_me2me_host: Don't try to display UI on top of Mac login screen

remoting_me2me_host: Don't try to display UI on top of Mac login screen

Trying to display the Disconnect window causes rejection from the Window Server on
OS X 10.7.4, preventing the capturer from working.

BUG=140984
TEST=Verify Chromoting works on the system login screen.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153610

[Jamie, 2012-08-24 21:40:25]

lgtm with a couple of suggestions.

http://codereview.chromium.org/10883033/diff/1/remoting/host/remoting_me2me_h...
File remoting/host/remoting_me2me_host.cc (right):

http://codereview.chromium.org/10883033/diff/1/remoting/host/remoting_me2me_h...
remoting/host/remoting_me2me_host.cc:252: host_user_interface_.reset(new
HostUserInterface(context_.get()));
Can you refactor a little so that we don't need to duplicate this line for Wind
and Mac?

http://codereview.chromium.org/10883033/diff/1/remoting/host/remoting_me2me_h...
remoting/host/remoting_me2me_host.cc:260: kCGSessionLoginDoneKey);
We now use this in a couple of places. Is it worth moving it somewhere central?

[Lambros, 2012-08-27 20:26:43]

http://codereview.chromium.org/10883033/diff/1/remoting/host/remoting_me2me_h...
File remoting/host/remoting_me2me_host.cc (right):

http://codereview.chromium.org/10883033/diff/1/remoting/host/remoting_me2me_h...
remoting/host/remoting_me2me_host.cc:252: host_user_interface_.reset(new
HostUserInterface(context_.get()));
On 2012/08/24 21:40:35, Jamie wrote:
> Can you refactor a little so that we don't need to duplicate this line for
Wind
> and Mac?

Done.

http://codereview.chromium.org/10883033/diff/1/remoting/host/remoting_me2me_h...
remoting/host/remoting_me2me_host.cc:260: kCGSessionLoginDoneKey);
On 2012/08/24 21:40:35, Jamie wrote:
> We now use this in a couple of places. Is it worth moving it somewhere
central?

We should move this into a separate utility class, used from here and the
curtain-mode code.  For now, I'd prefer to keep this CL small.

http://codereview.chromium.org/10883033/diff/3001/remoting/host/remoting_me2m...
File remoting/host/remoting_me2me_host.cc (left):

http://codereview.chromium.org/10883033/diff/3001/remoting/host/remoting_me2m...
remoting/host/remoting_me2me_host.cc:265: #if defined(OS_MACOSX) ||
defined(OS_WIN)
I think the code looks cleaner without these ifdefs.

[commit-bot: I haz the power, 2012-08-27 20:28:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/10883033/3001

[commit-bot: I haz the power, 2012-08-27 20:49:43]

Try job failure for 10883033-3001 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2012-08-27 22:07:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/10883033/3002

[commit-bot: I haz the power, 2012-08-28 02:43:36]

Change committed as 153610