remoting_me2me_host: Don't try to display UI on top of Mac login screen

remoting/host/remoting_me2me_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file implements a standalone host process for Me2Me.
 
 #include <string>
 
 #include "base/at_exit.h"
 #include "base/bind.h"
@@ skipping 230 matching lines @@
   // IPC::Listener implementation.
   virtual bool OnMessageReceived(const IPC::Message& message) {
     return false;
   }
 
   int Run() {
     if (!LoadConfig()) {
       return kInvalidHostConfigurationExitCode;
     }
 
-#if defined(OS_MACOSX) || defined(OS_WIN)
+#if defined(OS_WIN)
     host_user_interface_.reset(new HostUserInterface(context_.get()));

[Jamie, 2012/08/24 21:40:35]

Can you refactor a little so that we don't need to duplicate this line for Wind
and Mac?

[Lambros, 2012/08/27 20:26:44]

Done.

+#elif defined(OS_MACOSX)
+    // Don't try to display any UI on top of the system's login screen as this
+    // is rejected by the Window Server on OS X 10.7.4, and prevents the
+    // capturer from working (http://crbug.com/140984).
+    base::mac::ScopedCFTypeRef<CFDictionaryRef> session(
+        CGSessionCopyCurrentDictionary());
+    const void* logged_in = CFDictionaryGetValue(session,
+                                                 kCGSessionLoginDoneKey);

[Jamie, 2012/08/24 21:40:35]

We now use this in a couple of places. Is it worth moving it somewhere central?

[Lambros, 2012/08/27 20:26:44]

We should move this into a separate utility class, used from here and the
curtain-mode code.  For now, I'd prefer to keep this CL small.

+    if (logged_in == kCFBooleanTrue) {
+      host_user_interface_.reset(new HostUserInterface(context_.get()));
+    }
 #endif
 
     StartWatchingPolicy();
 
 #if defined(OS_MACOSX) || defined(OS_WIN)
     context_->file_task_runner()->PostTask(
         FROM_HERE,
         base::Bind(&HostProcess::ListenForConfigChanges,
                    base::Unretained(this)));
 #endif
@@ skipping 249 matching lines @@
     host_->SetMaximumSessionDuration(base::TimeDelta::FromHours(20));
 #endif
 
     heartbeat_sender_.reset(new HeartbeatSender(
         this, host_id_, signal_strategy_.get(), &key_pair_));
 
     log_to_server_.reset(
         new LogToServer(host_, ServerLogEntry::ME2ME, signal_strategy_.get()));
     host_event_logger_ = HostEventLogger::Create(host_, kApplicationName);
 
-#if defined(OS_MACOSX) || defined(OS_WIN)
-    host_user_interface_->Start(
-        host_, base::Bind(&HostProcess::OnDisconnectRequested,
-                          base::Unretained(this)));
-#endif
+    if (host_user_interface_.get()) {
+      host_user_interface_->Start(
+          host_, base::Bind(&HostProcess::OnDisconnectRequested,
+                            base::Unretained(this)));
+    }
 
     host_->Start();
 
     CreateAuthenticatorFactory();
   }
 
   void OnAuthFailed() {
     Shutdown(kInvalidOauthCredentialsExitCode);
   }
 
@@ skipping 194 matching lines @@
             user32.GetFunctionPointer("SetProcessDPIAware"));
     set_process_dpi_aware();
   }
 
   // CommandLine::Init() ignores the passed |argc| and |argv| on Windows getting
   // the command line from GetCommandLineW(), so we can safely pass NULL here.
   return main(0, NULL);
 }
 
 #endif  // defined(OS_WIN)