content/browser/web_contents/web_contents_impl.cc - Issue 10883031: Change disposition to POPUP for navigations in a new process with no user gesture to trigger popup …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 10883031: Change disposition to POPUP for navigations in a new process with no user gesture to trigger popup … (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_impl.cc

===================================================================

--- content/browser/web_contents/web_contents_impl.cc (revision 152370)

+++ content/browser/web_contents/web_contents_impl.cc (working copy)

@@ -1292,7 +1292,8 @@

// new window. As a result, we need to show and navigate the window here.

Charlie Reis 2012/08/24 21:30:26 Can you throw in a TODO to ensure we fix whitelist

gfx::Rect initial_pos;

AddNewContents(

- new_contents, params.disposition, initial_pos, params.user_gesture);

+ new_contents, params.user_gesture ? params.disposition : NEW_POPUP,

+ initial_pos, params.user_gesture);

content::OpenURLParams open_params(params.target_url, content::Referrer(),

CURRENT_TAB,

« no previous file with comments | « no previous file | no next file » | no next file with comments »