Change disposition to POPUP for navigations in a new process with no user gesture to trigger popup …

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
@@ skipping 1271 matching lines @@
     pending_contents_[route_id] = new_contents;
   }
 
   if (delegate_) {
     delegate_->WebContentsCreated(
         this, params.opener_frame_id, params.target_url, new_contents);
   }
 
   if (params.opener_suppressed) {
     // When the opener is suppressed, the original renderer cannot access the
     // new window.  As a result, we need to show and navigate the window here.

[Charlie Reis, 2012/08/24 21:30:26]

Can you throw in a TODO to ensure we fix whitelisted non-user-gesture
navigations after this?

     gfx::Rect initial_pos;
     AddNewContents(
-        new_contents, params.disposition, initial_pos, params.user_gesture);
+        new_contents, params.user_gesture ? params.disposition : NEW_POPUP,
+        initial_pos, params.user_gesture);
 
     content::OpenURLParams open_params(params.target_url, content::Referrer(),
                                        CURRENT_TAB,
                                        content::PAGE_TRANSITION_LINK,
                                        true /* is_renderer_initiated */);
     new_contents->OpenURL(open_params);
   }
 }
 
 void WebContentsImpl::CreateNewWidget(int route_id,
@@ skipping 1905 matching lines @@
       old_browser_plugin_host()->embedder_render_process_host();
   *embedder_container_id = old_browser_plugin_host()->instance_id();
   int embedder_process_id =
       embedder_render_process_host ? embedder_render_process_host->GetID() : -1;
   if (embedder_process_id != -1) {
     *embedder_channel_name =
         StringPrintf("%d.r%d", render_view_host->GetProcess()->GetID(),
                      embedder_process_id);
   }
 }