Port the Extension Install Bubble changes to Mac

chrome/browser/ui/cocoa/extensions/extension_installed_bubble_bridge.mm

Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_bridge.mm
===================================================================
--- chrome/browser/ui/cocoa/extensions/extension_installed_bubble_bridge.mm	(revision 152319)
+++ chrome/browser/ui/cocoa/extensions/extension_installed_bubble_bridge.mm	(working copy)
@@ -55,7 +55,8 @@
                                   const SkBitmap& icon) {
   if ((extension->browser_action()) || !extension->omnibox_keyword().empty() ||

[Nico, 2012/08/23 15:42:12]

Remove parens around first term

[Finnur, 2012/08/24 12:55:26]

Done. I also removed browser_action_command() altogether, because
browser_action() implies browser_action_command() -- page_action(), however,
does not imply page_action_command().

On 2012/08/23 15:42:12, Nico wrote:

       (extension->page_action() &&
-      !extension->page_action()->default_icon_path().empty())) {
+      !extension->page_action()->default_icon_path().empty()) ||
+      extension->browser_action_command() || extension->page_action_command()) {

[Nico, 2012/08/23 15:42:12]

This condition is unreadable. Is it the same on all platforms? If so, it should
probably be some method on Extension? should_show_install_bubble()?

[Finnur, 2012/08/24 12:55:26]

Mac is the only platform that decided to show the Extension Install as an
Infobar, the other platforms show the bubble. However, I've added
verbose_install_message(), which matches what you intended, I think.

On 2012/08/23 15:42:12, Nico wrote:

[Aaron Boodman, 2012/08/24 13:48:57]

If it helps at all, we want to remove the infobar on mac: crbug.com/109940.

     // The controller is deallocated when the window is closed, so no need to
     // worry about it here.
     [[ExtensionInstalledBubbleController alloc]