Port the Extension Install Bubble changes to Mac

chrome/browser/ui/cocoa/extensions/extension_installed_bubble_bridge.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/i18n/rtl.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/api/infobars/confirm_infobar_delegate.h"
 #include "chrome/browser/api/infobars/simple_alert_infobar_delegate.h"
@@ skipping 35 matching lines @@
   InfoBarDelegate* delegate = new SimpleAlertInfoBarDelegate(
       infobar_helper, new gfx::Image(icon), msg, true);
   infobar_helper->AddInfoBar(delegate);
 }
 
 namespace chrome {
 
 void ShowExtensionInstalledBubble(const extensions::Extension* extension,
                                   Browser* browser,
                                   const SkBitmap& icon) {
   if ((extension->browser_action()) || !extension->omnibox_keyword().empty() ||

[Nico, 2012/08/23 15:42:12]

Remove parens around first term

[Finnur, 2012/08/24 12:55:26]

Done. I also removed browser_action_command() altogether, because
browser_action() implies browser_action_command() -- page_action(), however,
does not imply page_action_command().

On 2012/08/23 15:42:12, Nico wrote:

       (extension->page_action() &&
-      !extension->page_action()->default_icon_path().empty())) {
+      !extension->page_action()->default_icon_path().empty()) ||
+      extension->browser_action_command() || extension->page_action_command()) {

[Nico, 2012/08/23 15:42:12]

This condition is unreadable. Is it the same on all platforms? If so, it should
probably be some method on Extension? should_show_install_bubble()?

[Finnur, 2012/08/24 12:55:26]

Mac is the only platform that decided to show the Extension Install as an
Infobar, the other platforms show the bubble. However, I've added
verbose_install_message(), which matches what you intended, I think.

On 2012/08/23 15:42:12, Nico wrote:

[Aaron Boodman, 2012/08/24 13:48:57]

If it helps at all, we want to remove the infobar on mac: crbug.com/109940.

     // The controller is deallocated when the window is closed, so no need to
     // worry about it here.
     [[ExtensionInstalledBubbleController alloc]
         initWithParentWindow:browser->window()->GetNativeWindow()
                    extension:extension
                       bundle:NULL
                      browser:browser
                         icon:icon];
   } else {
     // If the extension is of type GENERIC, meaning it doesn't have a UI
     // surface to display for this window, launch infobar instead of popup
     // bubble, because we have no guaranteed wrench menu button to point to.
     ShowGenericExtensionInstalledInfoBar(extension, browser, icon);
   }
 }
 
 }  // namespace chrome
 
 void extensions::BundleInstaller::ShowInstalledBubble(
     const BundleInstaller* bundle, Browser* browser) {
   // The controller is deallocated when the window is closed, so no need to
   // worry about it here.
   [[ExtensionInstalledBubbleController alloc]
         initWithParentWindow:browser->window()->GetNativeWindow()
                    extension:NULL
                       bundle:bundle
                      browser:browser
                         icon:SkBitmap()];
 }