UMA: Add PageLoad user action

chrome/browser/ui/browser_commands.cc

Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index be8f17a9cf9c28427c18133f551a5cb3401ab2f3..3fbff0771689f8b0e37e8626652850f7123fa803 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -341,7 +341,6 @@ void Home(Browser* browser, WindowOpenDisposition disposition) {
 }
 
 void OpenCurrentURL(Browser* browser) {
-  content::RecordAction(UserMetricsAction("LoadURL"));

[jar (doing other things), 2012/08/27 21:40:59]

Do you have any interest in seeing how these numbers compare to the new metric? 
By leaving this deprecated (perhaps with a comment, and TODO() ...remove) you
get to see what the difference is "during real usage."

WDYT?

Perf wise, this would not IMO have any impact (re: cost of the extra metric).

[Mark P, 2012/08/27 21:58:46]

Good question.  I don't see a good reason to compare the next numbers with the
old.  I know the new will generally be bigger, but how much so will vary
substantially by country.  At the moment, I don't see anything useful that could
come of this.  Push back if you want.  (I don't feel that strongly about
removing LoadURL, so if you feel strongly that I should keep it (in
intended-to-be-ignored form) then tell me.)

[jar (doing other things), 2012/08/27 22:11:34]

I'm wary that it would instantly "break" the current "counts" dashboard that was
historically resurrected (and maintained) by Ian F.  

IMO, unless you have a concurrent patch to fix those dashboards, you should
leave 'em both in... then migrate the dashboards (maybe use both, and have two
columns???), and then remove the old.

On 2012/08/27 21:58:46, Mark P wrote:

[Mark P, 2012/08/29 00:17:40]

Okay.  Restored LoadURL recording.  I'll remove in way down the line after the
dashboard migrates.

   LocationBar* location_bar = browser->window()->GetLocationBar();
   if (!location_bar)
     return;