UMA: Add PageLoad user action

chrome/browser/ui/browser_commands.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_commands.h"
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/bookmarks/bookmark_editor.h"
@@ skipping 323 matching lines @@
   content::RecordAction(UserMetricsAction("Home"));
   browser->OpenURL(OpenURLParams(
       browser->profile()->GetHomePage(), Referrer(), disposition,
       content::PageTransitionFromInt(
           content::PAGE_TRANSITION_AUTO_BOOKMARK |
           content::PAGE_TRANSITION_HOME_PAGE),
       false));
 }
 
 void OpenCurrentURL(Browser* browser) {
-  content::RecordAction(UserMetricsAction("LoadURL"));

[jar (doing other things), 2012/08/27 21:40:59]

Do you have any interest in seeing how these numbers compare to the new metric? 
By leaving this deprecated (perhaps with a comment, and TODO() ...remove) you
get to see what the difference is "during real usage."

WDYT?

Perf wise, this would not IMO have any impact (re: cost of the extra metric).

[Mark P, 2012/08/27 21:58:46]

Good question.  I don't see a good reason to compare the next numbers with the
old.  I know the new will generally be bigger, but how much so will vary
substantially by country.  At the moment, I don't see anything useful that could
come of this.  Push back if you want.  (I don't feel that strongly about
removing LoadURL, so if you feel strongly that I should keep it (in
intended-to-be-ignored form) then tell me.)

[jar (doing other things), 2012/08/27 22:11:34]

I'm wary that it would instantly "break" the current "counts" dashboard that was
historically resurrected (and maintained) by Ian F.  

IMO, unless you have a concurrent patch to fix those dashboards, you should
leave 'em both in... then migrate the dashboards (maybe use both, and have two
columns???), and then remove the old.

On 2012/08/27 21:58:46, Mark P wrote:

[Mark P, 2012/08/29 00:17:40]

Okay.  Restored LoadURL recording.  I'll remove in way down the line after the
dashboard migrates.

   LocationBar* location_bar = browser->window()->GetLocationBar();
   if (!location_bar)
     return;
 
   WindowOpenDisposition open_disposition =
       location_bar->GetWindowOpenDisposition();
   if (browser->instant_controller()->OpenInstant(open_disposition))
     return;
 
   GURL url(location_bar->GetInputString());
@@ skipping 627 matching lines @@
   if (!tab_contents)
     tab_contents = new TabContents(contents);
   app_browser->tab_strip_model()->AppendTabContents(tab_contents, true);
 
   contents->GetMutableRendererPrefs()->can_accept_load_drops = false;
   contents->GetRenderViewHost()->SyncRendererPrefs();
   app_browser->window()->Show();
 }
 
 }  // namespace chrome