Add --describe flag to {firmware|kernel}_utility.

Add --describe flag to {firmware|kernel}_utility.

This spews out useful information about a verified boot firmware/kernel image. Also adds a helper function to calculate header checksum. That code was being duplicated at multiple places.

[gauravsh, 2010-03-18 04:51:01]

Re-created the old botched code review.

[Chris Masone, 2010-03-18 05:32:17]

On 2010/03/18 04:51:01, gauravsh wrote:
> Re-created the old botched code review.

lgtm w/nits

[Chris Masone, 2010-03-18 05:32:28]

http://codereview.chromium.org/1088001/diff/2001/3002
File src/platform/vboot_reference/include/firmware_utility.h (right):

http://codereview.chromium.org/1088001/diff/2001/3002#newcode28
src/platform/vboot_reference/include/firmware_utility.h:28: // Print descriptio
of verified boot firmware image.
n?

http://codereview.chromium.org/1088001/diff/2001/3008
File src/platform/vboot_reference/utils/firmware_utility.cc (right):

http://codereview.chromium.org/1088001/diff/2001/3008#newcode238
src/platform/vboot_reference/utils/firmware_utility.cc:238: cerr << "One of
--generate or --verify must be specified.\n";
Correct this comment?  It seems like, "If not passing --describe, one and only
one of --generate or --verify must be specified." would be more appropriate.

http://codereview.chromium.org/1088001/diff/2001/3010
File src/platform/vboot_reference/utils/kernel_utility.cc (right):

http://codereview.chromium.org/1088001/diff/2001/3010#newcode284
src/platform/vboot_reference/utils/kernel_utility.cc:284: cerr << "One of
--generate or --verify must be specified.\n";
fix comment?

http://codereview.chromium.org/1088001/diff/2001/3010#newcode340
src/platform/vboot_reference/utils/kernel_utility.cc:340:
vboot_reference::KernelUtility fu;
Technically...s/ku/fu/g, right?

[gauravsh, 2010-03-18 20:10:40]

On Wed, Mar 17, 2010 at 10:32 PM,  <cmasone@chromium.org> wrote:
> http://codereview.chromium.org/1088001/diff/2001/3002
> File src/platform/vboot_reference/include/firmware_utility.h (right):
>
> http://codereview.chromium.org/1088001/diff/2001/3002#newcode28
> src/platform/vboot_reference/include/firmware_utility.h:28: // Print
> descriptio of verified boot firmware image.
> n?

Done.

>
> http://codereview.chromium.org/1088001/diff/2001/3008
> File src/platform/vboot_reference/utils/firmware_utility.cc (right):
>
> http://codereview.chromium.org/1088001/diff/2001/3008#newcode238
> src/platform/vboot_reference/utils/firmware_utility.cc:238: cerr << "One
> of --generate or --verify must be specified.\n";
> Correct this comment?  It seems like, "If not passing --describe, one
> and only one of --generate or --verify must be specified." would be more
> appropriate.

Done. (Actually had to fix the check, since the intention is that only
one of the 3 flags can be specified).

>
> http://codereview.chromium.org/1088001/diff/2001/3010
> File src/platform/vboot_reference/utils/kernel_utility.cc (right):
>
> http://codereview.chromium.org/1088001/diff/2001/3010#newcode284
> src/platform/vboot_reference/utils/kernel_utility.cc:284: cerr << "One
> of --generate or --verify must be specified.\n";
> fix comment?

Done.

>
> http://codereview.chromium.org/1088001/diff/2001/3010#newcode340
> src/platform/vboot_reference/utils/kernel_utility.cc:340:
> vboot_reference::KernelUtility fu;
> Technically...s/ku/fu/g, right?

Done.

>
> http://codereview.chromium.org/1088001
>

-- 
-g

[gauravsh, 2010-03-18 20:11:08]

And Submitted...

On Thu, Mar 18, 2010 at 1:10 PM, Gaurav Shah <gauravsh@chromium.org> wrote:
> On Wed, Mar 17, 2010 at 10:32 PM,  <cmasone@chromium.org> wrote:
>> http://codereview.chromium.org/1088001/diff/2001/3002
>> File src/platform/vboot_reference/include/firmware_utility.h (right):
>>
>> http://codereview.chromium.org/1088001/diff/2001/3002#newcode28
>> src/platform/vboot_reference/include/firmware_utility.h:28: // Print
>> descriptio of verified boot firmware image.
>> n?
>
> Done.
>
>>
>> http://codereview.chromium.org/1088001/diff/2001/3008
>> File src/platform/vboot_reference/utils/firmware_utility.cc (right):
>>
>> http://codereview.chromium.org/1088001/diff/2001/3008#newcode238
>> src/platform/vboot_reference/utils/firmware_utility.cc:238: cerr << "One
>> of --generate or --verify must be specified.\n";
>> Correct this comment?  It seems like, "If not passing --describe, one
>> and only one of --generate or --verify must be specified." would be more
>> appropriate.
>
> Done. (Actually had to fix the check, since the intention is that only
> one of the 3 flags can be specified).
>
>>
>> http://codereview.chromium.org/1088001/diff/2001/3010
>> File src/platform/vboot_reference/utils/kernel_utility.cc (right):
>>
>> http://codereview.chromium.org/1088001/diff/2001/3010#newcode284
>> src/platform/vboot_reference/utils/kernel_utility.cc:284: cerr << "One
>> of --generate or --verify must be specified.\n";
>> fix comment?
>
> Done.
>
>>
>> http://codereview.chromium.org/1088001/diff/2001/3010#newcode340
>> src/platform/vboot_reference/utils/kernel_utility.cc:340:
>> vboot_reference::KernelUtility fu;
>> Technically...s/ku/fu/g, right?
>
> Done.
>
>>
>> http://codereview.chromium.org/1088001
>>
>
> --
> -g
>



-- 
-g