Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 10879112: Revert 153612 - Add Chrome Endure graph plotting code. (broke Chrome OS) (Closed)

Created:
8 years, 3 months ago by jschuh
Modified:
8 years, 3 months ago
Reviewers:
dennis_jeffrey
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh
Visibility:
Public.

Description

Revert 153612 - Add Chrome Endure graph plotting code. (broke Chrome OS) Chrome Endure refers to an endurance testing effort to study the effect of memory bloat in webapps running in chrome. This code is a fork of chrome's existing code for displaying performance graphs. It has become very specific to Chrome Endure, containing features requested by users of Chrome Endure, and having the ability to display performance results across time within a given test run (as compared to the existing chrome perf graphs, which display data across test runs). In addition to adding new features specific to Chrome Endure, the current code removes some features that originally existed from chrome's perf graphing code, which haven't been used for Chrome Endure. This code has been running for awhile to display Chrome Endure perf graphs, but hasn't been checked in until now. Other users want to build on top of this codebase to add new graphing features specific to Chrome Endure. BUG=chromium-os:32302 TEST=Verified that graphs work well enough for current Chrome Endure purposes. Review URL: https://chromiumcodereview.appspot.com/10832403 TBR=dennisjeffrey@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1619 lines) Patch
D chrome/test/functional/perf/endure_graphs/endure_plotter.html View 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/test/functional/perf/endure_graphs/endure_plotter.js View 1 chunk +0 lines, -523 lines 0 comments Download
D chrome/test/functional/perf/endure_graphs/js/common.js View 1 chunk +0 lines, -89 lines 0 comments Download
D chrome/test/functional/perf/endure_graphs/js/coordinates.js View 1 chunk +0 lines, -131 lines 0 comments Download
D chrome/test/functional/perf/endure_graphs/js/plotter.js View 1 chunk +0 lines, -765 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jschuh
8 years, 3 months ago (2012-08-28 04:04:01 UTC) #1
jschuh
8 years, 3 months ago (2012-08-28 04:05:43 UTC) #2
Broke Chrome OS:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

/b/build/slave/Linux_ChromiumOS/build/src/chrome/test/functional/perf/endure_graphs/endure_plotter.html:
Must not have executable bit set
/b/build/slave/Linux_ChromiumOS/build/src/chrome/test/functional/perf/endure_graphs/endure_plotter.js:
Must not have executable bit set
/b/build/slave/Linux_ChromiumOS/build/src/chrome/test/functional/perf/endure_graphs/js/common.js:
Must not have executable bit set
/b/build/slave/Linux_ChromiumOS/build/src/chrome/test/functional/perf/endure_graphs/js/coordinates.js:
Must not have executable bit set
/b/build/slave/Linux_ChromiumOS/build/src/chrome/test/functional/perf/endure_graphs/js/plotter.js:
Must not have executable bit set

Powered by Google App Engine
This is Rietveld 408576698