Remote all monitors on multi-monitor Mac OS X systems.

remoting/host/event_executor_mac.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/event_executor.h"
 
 #include <ApplicationServices/ApplicationServices.h>
 #include <Carbon/Carbon.h>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/location.h"
 #include "base/mac/scoped_cftyperef.h"
 #include "base/single_thread_task_runner.h"
 #include "remoting/host/clipboard.h"
 #include "remoting/proto/internal.pb.h"
 #include "remoting/protocol/message_decoder.h"
 #include "third_party/skia/include/core/SkPoint.h"
+#include "third_party/skia/include/core/SkRect.h"
 
 namespace remoting {
 
 namespace {
 
 using protocol::ClipboardEvent;
 using protocol::KeyEvent;
 using protocol::MouseEvent;
 
 // USB to Mac keycode mapping table.
 #define USB_KEYMAP(usb, xkb, win, mac) {usb, mac}
 #include "ui/base/keycodes/usb_keycode_map.h"
 #undef USB_KEYMAP
 
+SkIRect CGRectToSkIRect(const CGRect& rect) {

[Jamie, 2012/08/30 20:53:53]

skia/ext/skia_utils_mac.h defines this function. If there's some reason we can't
use it, please add a comment explaining why.

[Wez, 2012/08/31 00:47:42]

Sadly, it defines only CGRectToSkRect(), not CGRectToSkIRect().

[Jamie, 2012/08/31 01:20:02]

I was about to suggest adding it, but then I saw
http://codereview.chromium.org/9705064, which specifically moved it here, so I
guess it stays :D

+  SkIRect sk_rect = {
+    SkScalarRound(rect.origin.x),
+    SkScalarRound(rect.origin.y),
+    SkScalarRound(rect.origin.x + rect.size.width),
+    SkScalarRound(rect.origin.y + rect.size.height)
+  };
+  return sk_rect;
+}
+
 // A class to generate events on Mac.
 class EventExecutorMac : public EventExecutor {
  public:
   EventExecutorMac(scoped_refptr<base::SingleThreadTaskRunner> task_runner);
   virtual ~EventExecutorMac() {}
 
   // ClipboardStub interface.
   virtual void InjectClipboardEvent(const ClipboardEvent& event) OVERRIDE;
 
   // InputStub interface.
@@ skipping 256 matching lines @@
 #pragma clang diagnostic ignored "-Wdeprecated-declarations"
   CGError error = CGPostKeyboardEvent(0, keycode, event.pressed());
 #pragma clang diagnostic pop
   if (error != kCGErrorSuccess) {
     LOG(WARNING) << "CGPostKeyboardEvent error " << error;
   }
 }
 
 void EventExecutorMac::InjectMouseEvent(const MouseEvent& event) {
   if (event.has_x() && event.has_y()) {
-    // TODO(wez): This code assumes that MouseEvent(0,0) (top-left of client view)
-    // corresponds to local (0,0) (top-left of primary monitor).  That won't in
-    // general be true on multi-monitor systems, though.
+    // On multi-monitor systems (0,0) refers to the top-left of the "main"
+    // display, whereas our coordinate scheme places (0,0) at the top-left of
+    // the bounding rectangle around all the displays, so we need to translate
+    // accordingly.
+    // TODO(wez): Move display config tracking into a separate class used both
+    // here and in the Capturer.

[Jamie, 2012/08/30 20:53:53]

I assume this would allow us to avoid doing this calculation for every mouse
event?

[Wez, 2012/08/31 00:47:42]

If it registered for display-change notifications and notified a caller-supplied
callback then yes.

+
+    // Set the mouse position assuming single-monitor.
+    mouse_pos_ = SkIPoint::Make(event.x(), event.y());
+
+    // Determine how many active displays there are.
+    CGDisplayCount display_count;
+    CGError error = CGGetActiveDisplayList(0, NULL, &display_count);
+    CHECK_EQ(error, CGDisplayNoErr);
+
+    if (display_count > 1) {
+      // Determine the bounding box of the displays, to get the top-left origin.
+      std::vector<CGDirectDisplayID> display_ids(display_count);
+      error = CGGetActiveDisplayList(display_count, &display_ids[0],
+                                     &display_count);
+      CHECK_EQ(error, CGDisplayNoErr);
+      CHECK_EQ(display_count, display_ids.size());
+
+      SkIRect desktop_bounds = SkIRect::MakeEmpty();
+      for (unsigned int d = 0; d < display_count; ++d) {
+        CGRect display_bounds = CGDisplayBounds(display_ids[d]);
+        desktop_bounds.join(CGRectToSkIRect(display_bounds));
+      }
+
+      // Adjust the injected mouse event position.
+      mouse_pos_ += SkIPoint::Make(desktop_bounds.left(), desktop_bounds.top());
+    }
+
     VLOG(3) << "Moving mouse to " << event.x() << "," << event.y();
-    mouse_pos_ = SkIPoint::Make(event.x(), event.y());
   }
   if (event.has_button() && event.has_button_down()) {
     if (event.button() >= 1 && event.button() <= 3) {
       VLOG(2) << "Button " << event.button()
               << (event.button_down() ? " down" : " up");
       int button_change = 1 << (event.button() - 1);
       if (event.button_down())
         mouse_button_state_ |= button_change;
       else
         mouse_button_state_ &= ~button_change;
@@ skipping 66 matching lines @@
 
 }  // namespace
 
 scoped_ptr<EventExecutor> EventExecutor::Create(
     scoped_refptr<base::SingleThreadTaskRunner> main_task_runner,
     scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner) {
   return scoped_ptr<EventExecutor>(new EventExecutorMac(main_task_runner));
 }
 
 }  // namespace remoting