Issue 9705064: remoting: Move CGRectToSkIRect() to the only file where it's called

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9705064: remoting: Move CGRectToSkIRect() to the only file where it's called (Closed)

Created:
8 years, 9 months ago by Nico

Modified:
8 years, 9 months ago

Reviewers:
dmac, Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

remoting: Move CGRectToSkIRect() to the only file where it's called The alternative would be to add SK_API to that function. BUG=90078 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127036

Patch Set 1 #

Patch Set 2 : . #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -14 lines)			Patch
M	remoting/host/capturer_mac.cc	View	1	3 chunks	+12 lines, -3 lines	0 comments	Download
M	skia/ext/skia_utils_mac.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	skia/ext/skia_utils_mac.mm	View		1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9705064/3001

8 years, 9 months ago (2012-03-15 17:40:15 UTC) #3

commit-bot: I haz the power

Try job failure for 9705064-3001 (retry) on mac_rel for step "browser_tests". It's a second try, ...

8 years, 9 months ago (2012-03-15 20:15:58 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9705064/3001

8 years, 9 months ago (2012-03-15 20:53:08 UTC) #5

Change committed as 127036

Expand Messages | Collapse Messages