chrome/renderer/extensions/miscellaneous_bindings.cc - Issue 10877004: Split a CHECK in 2 in MiscellaneousBindings::DispatchOnConnect to help

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/miscellaneous_bindings.cc

Issue 10877004: Split a CHECK in 2 in MiscellaneousBindings::DispatchOnConnect to help (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/miscellaneous_bindings.cc

diff --git a/chrome/renderer/extensions/miscellaneous_bindings.cc b/chrome/renderer/extensions/miscellaneous_bindings.cc

index 3e05d2d4814c9d48bacd3c6105e6493dd5a8fca0..8ae7c8418c31b5ebf9e8e7f359249b77db86663d 100644

--- a/chrome/renderer/extensions/miscellaneous_bindings.cc

+++ b/chrome/renderer/extensions/miscellaneous_bindings.cc

@@ -220,7 +220,8 @@ void MiscellaneousBindings::DispatchOnConnect(

continue;

}

- CHECK(!retval.IsEmpty() && retval->IsBoolean());

+ CHECK(!retval.IsEmpty());

+ CHECK(retval->IsBoolean());

if (retval->BooleanValue())

port_created = true;

}