Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10877004: Split a CHECK in 2 in MiscellaneousBindings::DispatchOnConnect to help (Closed)

Created:
8 years, 4 months ago by Matt Perry
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Split a CHECK in 2 in MiscellaneousBindings::DispatchOnConnect to help debug which clause is failing. Also remove some dead code in extensions::Dispatcher. BUG=134175 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152939

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M chrome/renderer/extensions/dispatcher.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/renderer/extensions/miscellaneous_bindings.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Matt Perry
8 years, 4 months ago (2012-08-22 01:17:03 UTC) #1
Mihai Parparita -not on Chrome
LGTM http://codereview.chromium.org/10877004/diff/1/chrome/renderer/extensions/dispatcher.h File chrome/renderer/extensions/dispatcher.h (right): http://codereview.chromium.org/10877004/diff/1/chrome/renderer/extensions/dispatcher.h#newcode225 chrome/renderer/extensions/dispatcher.h:225: // The v8 extensions which are restricted to ...
8 years, 4 months ago (2012-08-22 23:36:32 UTC) #2
Matt Perry
http://codereview.chromium.org/10877004/diff/1/chrome/renderer/extensions/dispatcher.h File chrome/renderer/extensions/dispatcher.h (right): http://codereview.chromium.org/10877004/diff/1/chrome/renderer/extensions/dispatcher.h#newcode225 chrome/renderer/extensions/dispatcher.h:225: // The v8 extensions which are restricted to extension-related ...
8 years, 4 months ago (2012-08-23 00:22:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10877004/8001
8 years, 4 months ago (2012-08-23 00:23:30 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-23 03:25:43 UTC) #5 
Change committed as 152939

Powered by Google App Engine
This is Rietveld 408576698