AddEntryToDirectory now takes a FilePath and scoped_ptr<DocumentEntry>

AddEntryToDirectory now takes a FilePath and scoped_ptr<DocumentEntry>

* DriveResourceMetadata::AddEntryToDirectory now takes a FilePath and scoped_ptr<DocumentEntry>.
* DriveFileSystem::AddUploadedParams now take a directory FilePath and a scoped_ptr<DocumentEntry>.
* Anon helper function PostError in drive_resource_metadata.cc posts an async callback error.
* DriveFileSystem's OnCreateDirectoryCompleted renamed to AddNewDirectory. The old synchronous AddNewDirectory is gone, replaced by a call to DriveResourceMetadata::AddEntryToDirectory, continuing with DriveFileSystem::ContinueCreateDirectory.
* DriveFileSystem's CreateDirectoryParams has moved to the header file so AddNewDirectory may be called by the unit test.
* DriveFileSystem's RenameEntryLocally, RenameAfterGetEntryInfo and NotifyAndRunFileMoveCallback now require a non-null callback.
* AddUploadedFileToCache calls OnDirectoryChanged directly instead of the indirection through NotifyAndRunFileMoveCallback. Also additional DCHECKs in AddUploadedFileToCache.
* callback_runner no longer necessary in AddUploadedFileOnUIThread.
* entry replaced with doc_entry everywhere to avoid confusion with GDataEntry.
* virtual_dir_path replaced with directory_path everywhere for consistency.
* delete FindEntryCallback, which is no longer used.

BUG=142048
TEST=unit tests
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153582

[achuithb, 2012-08-26 04:29:14]

Please review, Ryo-san and Satoru-san. Thank you!

[hashimoto, 2012-08-27 20:36:41]

http://codereview.chromium.org/10876075/diff/3004/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/drive_file_system.h (right):

http://codereview.chromium.org/10876075/diff/3004/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/drive_file_system.h:168: struct
CreateDirectoryParams {
Hmm, I'd like to keep this in .cc file but test code needs it…

http://codereview.chromium.org/10876075/diff/3004/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/drive_resource_metadata.cc (right):

http://codereview.chromium.org/10876075/diff/3004/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/drive_resource_metadata.cc:45: void
PostError(const FileMoveCallback& callback, DriveFileError error) {
Move this to the anonymous namespace.

http://codereview.chromium.org/10876075/diff/3004/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/drive_resource_metadata.cc:235: if
(!doc_entry.get()) {
Can we remove this since we have DCHECK(doc_entry.get())?

[achuithb, 2012-08-27 21:20:34]

http://codereview.chromium.org/10876075/diff/3004/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/drive_resource_metadata.cc (right):

http://codereview.chromium.org/10876075/diff/3004/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/drive_resource_metadata.cc:45: void
PostError(const FileMoveCallback& callback, DriveFileError error) {
On 2012/08/27 20:36:41, hashimoto wrote:
> Move this to the anonymous namespace.

Sorry thought I had. Done.

http://codereview.chromium.org/10876075/diff/3004/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/drive_resource_metadata.cc:235: if
(!doc_entry.get()) {
On 2012/08/27 20:36:41, hashimoto wrote:
> Can we remove this since we have DCHECK(doc_entry.get())?

I think we need this. Removed the DCHECK. We are getting doc entry essentially
from the server, so we can't really DCHECK.

[achuithb, 2012-08-27 21:33:04]

PTAL

[hashimoto, 2012-08-27 22:21:00]

lgtm

[satorux1, 2012-08-27 22:45:56]

I like this patch. LGTM with nits.

http://codereview.chromium.org/10876075/diff/13001/chrome/browser/chromeos/gd...
File chrome/browser/chromeos/gdata/drive_file_system.cc (right):

http://codereview.chromium.org/10876075/diff/13001/chrome/browser/chromeos/gd...
chrome/browser/chromeos/gdata/drive_file_system.cc:3240: }  // namespace gdata
74 lines reduced. cool!

http://codereview.chromium.org/10876075/diff/13001/chrome/browser/chromeos/gd...
File chrome/browser/chromeos/gdata/drive_file_system_unittest.cc (right):

http://codereview.chromium.org/10876075/diff/13001/chrome/browser/chromeos/gd...
chrome/browser/chromeos/gdata/drive_file_system_unittest.cc:328: directory_path,
directory_path, false, false,
align parameters vertically? please also add comments to the false false as
these are cryptic.

http://codereview.chromium.org/10876075/diff/13001/chrome/browser/chromeos/gd...
File chrome/browser/chromeos/gdata/drive_resource_metadata.cc (right):

http://codereview.chromium.org/10876075/diff/13001/chrome/browser/chromeos/gd...
chrome/browser/chromeos/gdata/drive_resource_metadata.cc:31: void
PostError(const FileMoveCallback& callback, DriveFileError error) {
function comment missing. this seems to be used to run a callback with an error
code asynchronously.

[achuithb, 2012-08-27 23:10:03]

Thanks for the reviews, Ryo-san and Satoru-san!

http://codereview.chromium.org/10876075/diff/13001/chrome/browser/chromeos/gd...
File chrome/browser/chromeos/gdata/drive_file_system_unittest.cc (right):

http://codereview.chromium.org/10876075/diff/13001/chrome/browser/chromeos/gd...
chrome/browser/chromeos/gdata/drive_file_system_unittest.cc:328: directory_path,
directory_path, false, false,
On 2012/08/27 22:45:57, satorux1 wrote:
> align parameters vertically? please also add comments to the false false as
> these are cryptic.

Done.

http://codereview.chromium.org/10876075/diff/13001/chrome/browser/chromeos/gd...
File chrome/browser/chromeos/gdata/drive_resource_metadata.cc (right):

http://codereview.chromium.org/10876075/diff/13001/chrome/browser/chromeos/gd...
chrome/browser/chromeos/gdata/drive_resource_metadata.cc:31: void
PostError(const FileMoveCallback& callback, DriveFileError error) {
On 2012/08/27 22:45:57, satorux1 wrote:
> function comment missing. this seems to be used to run a callback with an
error
> code asynchronously.

Done.