Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5441)

Unified Diff: chrome/browser/chromeos/gdata/drive_resource_metadata.h

Issue 10876075: AddEntryToDirectory now takes a FilePath and scoped_ptr<DocumentEntry> (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: rebase Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/gdata/drive_resource_metadata.h
===================================================================
--- chrome/browser/chromeos/gdata/drive_resource_metadata.h (revision 153571)
+++ chrome/browser/chromeos/gdata/drive_resource_metadata.h (working copy)
@@ -64,11 +64,6 @@
// drive.proto.
const int32 kProtoVersion = 2;
-// Callback type used to get result of file search.
-// If |error| is not PLATFORM_FILE_OK, |entry| is set to NULL.
-typedef base::Callback<void(DriveFileError error, DriveEntry* entry)>
- FindEntryCallback;
-
// Used for file operations like removing files.
typedef base::Callback<void(DriveFileError error)>
FileOperationCallback;
@@ -168,12 +163,11 @@
// Sets root directory resource id and initialize the root entry.
void InitializeRootEntry(const std::string& root_id);
- // Add |new entry| to |directory| and invoke the callback asynchronously.
+ // Add |doc entry| to directory with path |directory_path| and invoke the
+ // callback asynchronously.
// |callback| may not be null.
- // TODO(achuith,satorux): Use DriveEntryProto instead for new_entry.
- // crbug.com/142048
- void AddEntryToDirectory(DriveDirectory* directory,
- DriveEntry* new_entry,
+ void AddEntryToDirectory(const FilePath& directory_path,
+ scoped_ptr<DocumentEntry> doc_entry,
const FileMoveCallback& callback);
// Moves |entry| to |directory_path| asynchronously. Removes entry from
« no previous file with comments | « chrome/browser/chromeos/gdata/drive_file_system_unittest.cc ('k') | chrome/browser/chromeos/gdata/drive_resource_metadata.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698