Consume user gestures when navigating in a new tab/window. This ensures that a site can not create …

content/renderer/render_view_impl.cc

Index: content/renderer/render_view_impl.cc
===================================================================
--- content/renderer/render_view_impl.cc	(revision 153306)
+++ content/renderer/render_view_impl.cc	(working copy)
@@ -1627,6 +1627,9 @@
                              const GURL& url,
                              const Referrer& referrer,
                              WebNavigationPolicy policy) {
+  if (frame->isProcessingUserGesture())
+    frame->consumeUserGesture();

[abarth-chromium, 2012/08/27 19:46:05]

Can we just call this unconditionally?

+
   Send(new ViewHostMsg_OpenURL(
       routing_id_,
       url,
@@ -1718,6 +1721,10 @@
   int32 surface_id = 0;
   int64 cloned_session_storage_namespace_id;
 
+  // Consume a user gesture if we have one.
+  if (creator->isProcessingUserGesture())
+    creator->consumeUserGesture();

[abarth-chromium, 2012/08/27 19:46:05]

We need to do this both for OpenURL and createView ?  I would have hoped we
would only need to do this in one place (likely here).  Also, this comment is
kind of useless because it just restates what the code below it says.

+
   RenderThread::Get()->Send(
       new ViewHostMsg_CreateWindow(params,
                                    &routing_id,