Consume user gestures when navigating in a new tab/window. This ensures that a site can not create …

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 1609 matching lines @@
     return;
 
   Send(new ViewHostMsg_UpdateState(
       routing_id_, page_id_, webkit_glue::HistoryItemToString(item)));
 }
 
 void RenderViewImpl::OpenURL(WebFrame* frame,
                              const GURL& url,
                              const Referrer& referrer,
                              WebNavigationPolicy policy) {
+  if (frame->isProcessingUserGesture())
+    frame->consumeUserGesture();

[abarth-chromium, 2012/08/27 19:46:05]

Can we just call this unconditionally?

+
   Send(new ViewHostMsg_OpenURL(
       routing_id_,
       url,
       referrer,
       NavigationPolicyToDisposition(policy),
       frame->identifier()));
 }
 
 // WebViewDelegate ------------------------------------------------------------
 
@@ skipping 71 matching lines @@
       creator->document().securityOrigin().toString().utf8();
   params.opener_suppressed = creator->willSuppressOpenerInNewFrame();
   params.disposition = NavigationPolicyToDisposition(policy);
   if (!request.isNull())
     params.target_url = request.url();
 
   int32 routing_id = MSG_ROUTING_NONE;
   int32 surface_id = 0;
   int64 cloned_session_storage_namespace_id;
 
+  // Consume a user gesture if we have one.
+  if (creator->isProcessingUserGesture())
+    creator->consumeUserGesture();

[abarth-chromium, 2012/08/27 19:46:05]

We need to do this both for OpenURL and createView ?  I would have hoped we
would only need to do this in one place (likely here).  Also, this comment is
kind of useless because it just restates what the code below it says.

+
   RenderThread::Get()->Send(
       new ViewHostMsg_CreateWindow(params,
                                    &routing_id,
                                    &surface_id,
                                    &cloned_session_storage_namespace_id));
   if (routing_id == MSG_ROUTING_NONE)
     return NULL;
 
   // TODO(fsamuel): The host renderer needs to be able to control whether
   // the guest renderer is allowed to do this or not. This current
@@ skipping 4154 matching lines @@
 bool RenderViewImpl::WebWidgetHandlesCompositorScheduling() const {
   return !!RenderThreadImpl::current()->compositor_thread();
 }
 
 void RenderViewImpl::OnJavaBridgeInit() {
   DCHECK(!java_bridge_dispatcher_);
 #if defined(ENABLE_JAVA_BRIDGE)
   java_bridge_dispatcher_ = new JavaBridgeDispatcher(this);
 #endif
 }