ppapi: Make sure the touch-event interface is detected correctly.

ppapi: Make sure the touch-event interface is detected correctly.

BUG=145235
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154085

[brettw, 2012-08-27 17:22:38]

I don't think the paint manager example is the right place for a touch demo. Can
you make a new directory ppapi/examples/input and write a touch example there?
You can use the paint manager as a template.

It seems likely that we would want to expand on this a bit over time so we can
test different gestures, etc.

I'd also like a touch input event that shows you can create and query basic
properties in ppapi/test/test_input_event.cc. It doesn't have to be super
complicated, but I want to prevent this registration stuff from regressing.

[James Cook, 2012-08-27 17:32:09]

On 2012/08/27 17:22:38, brettw wrote:
> I don't think the paint manager example is the right place for a touch demo.
Can
> you make a new directory ppapi/examples/input and write a touch example there?
> You can use the paint manager as a template.
> 
> It seems likely that we would want to expand on this a bit over time so we can
> test different gestures, etc.
> 
> I'd also like a touch input event that shows you can create and query basic
> properties in ppapi/test/test_input_event.cc. It doesn't have to be super
> complicated, but I want to prevent this registration stuff from regressing.

FYI - This patch fixes my problem.  My plugin is properly receiving the three
touch point lists.

[sadrul, 2012-08-27 20:48:02]

On 2012/08/27 17:22:38, brettw wrote:
> I don't think the paint manager example is the right place for a touch demo.
Can
> you make a new directory ppapi/examples/input and write a touch example there?
> You can use the paint manager as a template.
> 
> It seems likely that we would want to expand on this a bit over time so we can
> test different gestures, etc.

I couldn't think of a better demo example. So I have copied the paint-demo and
added the touch-bits to it.

> I'd also like a touch input event that shows you can create and query basic
> properties in ppapi/test/test_input_event.cc. It doesn't have to be super
> complicated, but I want to prevent this registration stuff from regressing.

Done. PTAL.

[sadrul, 2012-08-28 19:18:40]

PTAL.

http://codereview.chromium.org/10873074/diff/19002/ppapi/tests/test_input_eve...
File ppapi/tests/test_input_event.cc (right):

http://codereview.chromium.org/10873074/diff/19002/ppapi/tests/test_input_eve...
ppapi/tests/test_input_event.cc:356: #if !defined(PPAPI_OS_WIN)
The test passes on debug builds, but fails on release builds. So I have disabled
this test on windows. I filed a bug for this and assigned to girard@ who has
worked on touch-events on windows.

[brettw, 2012-08-29 07:01:43]

If you're not going to finish this I'd rather have somebody else take over this
current patch rather than leaving it mysteriously hanging on Windows and filing
a bug for the issue.

[James Cook, 2012-08-29 18:17:34]

I'm not set up for Windows development, but please let me know if I can help
with this somehow.  Touch input for Inception is blocked on this issue.

[sadrul, 2012-08-29 22:13:07]

On 2012/08/29 07:01:43, brettw wrote:
> If you're not going to finish this I'd rather have somebody else take over
this
> current patch rather than leaving it mysteriously hanging on Windows and
filing
> a bug for the issue.

It looks like the test failure was caused by some uninitialized fields in the
touch-point created for the test. The fact that the test was passing on chromeos
and win-dbg made me think perhaps it was a win-rel specific issues. The test is
now passing on windows. Yay :)

PTAL.

[brettw, 2012-08-30 05:33:13]

Thanks! LGTM