Cleaned up codec_test.cc

Cleaned up codec_test.cc

BUG=92086
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153361

[kxing, 2012-08-24 20:13:45]

Hey Wez, could you PTAL?

[Wez, 2012-08-24 20:57:31]

http://codereview.chromium.org/10871068/diff/1/remoting/codec/codec_test.cc
File remoting/codec/codec_test.cc (left):

http://codereview.chromium.org/10871068/diff/1/remoting/codec/codec_test.cc#o...
remoting/codec/codec_test.cc:327: *memory = new uint8[memory_size];
This allocates a buffer of the necessary size; you need to do the same and
memory->reset() it, I think?

http://codereview.chromium.org/10871068/diff/1/remoting/codec/codec_test.cc
File remoting/codec/codec_test.cc (right):

http://codereview.chromium.org/10871068/diff/1/remoting/codec/codec_test.cc#n...
remoting/codec/codec_test.cc:366: new uint8[kSize.width() * kSize.height() *
kBytesPerPixel]);
Move this back into PrepareEncodeData, as per previous comment, so that there's
no possibility of the amount of memory being written to differing from the
amount allocated?

[kxing, 2012-08-24 21:28:29]

Hey Wez, could you PTAL again?

http://codereview.chromium.org/10871068/diff/1/remoting/codec/codec_test.cc
File remoting/codec/codec_test.cc (left):

http://codereview.chromium.org/10871068/diff/1/remoting/codec/codec_test.cc#o...
remoting/codec/codec_test.cc:327: *memory = new uint8[memory_size];
On 2012/08/24 20:57:31, Wez wrote:
> This allocates a buffer of the necessary size; you need to do the same and
> memory->reset() it, I think?

Done.

http://codereview.chromium.org/10871068/diff/1/remoting/codec/codec_test.cc
File remoting/codec/codec_test.cc (right):

http://codereview.chromium.org/10871068/diff/1/remoting/codec/codec_test.cc#n...
remoting/codec/codec_test.cc:366: new uint8[kSize.width() * kSize.height() *
kBytesPerPixel]);
On 2012/08/24 20:57:31, Wez wrote:
> Move this back into PrepareEncodeData, as per previous comment, so that
there's
> no possibility of the amount of memory being written to differing from the
> amount allocated?

Done.

[Wez, 2012-08-24 21:37:06]

lgtm

[commit-bot: I haz the power, 2012-08-24 21:40:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kxing@chromium.org/10871068/4001

[commit-bot: I haz the power, 2012-08-25 00:33:51]

Change committed as 153361