Make sure the Commands list correctly reflects the status of extensions right after install/uninsta…

Make sure the Commands list correctly reflects the status of extensions right after extension load/unload.

BUG=121420
TEST=Right after installing/uninstalling an extension with an Extension Command, the Configure Commands link should be visible/not visible (respectively) and the list of commands should be up to date (not need refresh).
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153489

[Finnur, 2012-08-24 13:50:51]

Yoyo, can you review?
jhawkins: Can you give OWNERS approval?

Thanks!

[James Hawkins, 2012-08-24 15:24:25]

LGTM with nit.

https://chromiumcodereview.appspot.com/10870068/diff/1/chrome/browser/ui/webu...
File chrome/browser/ui/webui/extensions/command_handler.h (right):

https://chromiumcodereview.appspot.com/10870068/diff/1/chrome/browser/ui/webu...
chrome/browser/ui/webui/extensions/command_handler.h:42: virtual void
Observe(int type, const content::NotificationSource& source,
nit: Method declarations must have one parameter per-line if they don't all fit
one one line.

[Yoyo Zhou, 2012-08-24 16:00:40]

http://codereview.chromium.org/10870068/diff/1/chrome/browser/ui/webui/extens...
File chrome/browser/ui/webui/extensions/command_handler.cc (right):

http://codereview.chromium.org/10870068/diff/1/chrome/browser/ui/webui/extens...
chrome/browser/ui/webui/extensions/command_handler.cc:49: registrar_.Add(this,
chrome::NOTIFICATION_EXTENSION_UNINSTALLED,
You wrote install/uninstall in the CL description, but this is load/uninstall.
It should be either load/unload or install/uninstall.

http://codereview.chromium.org/10870068/diff/1/chrome/browser/ui/webui/extens...
File chrome/browser/ui/webui/extensions/command_handler.h (right):

http://codereview.chromium.org/10870068/diff/1/chrome/browser/ui/webui/extens...
chrome/browser/ui/webui/extensions/command_handler.h:42: virtual void
Observe(int type, const content::NotificationSource& source,
On 2012/08/24 15:24:26, James Hawkins wrote:
> nit: Method declarations must have one parameter per-line if they don't all
fit
> one one line.

Also, this can be private.

http://codereview.chromium.org/10870068/diff/1/chrome/browser/ui/webui/extens...
chrome/browser/ui/webui/extensions/command_handler.h:66: // Used to observe
notifications.
nit: IMHO, unnecessary comment.

[Finnur, 2012-08-27 11:46:02]

Yoyo: PTAL

http://codereview.chromium.org/10870068/diff/1/chrome/browser/ui/webui/extens...
File chrome/browser/ui/webui/extensions/command_handler.cc (right):

http://codereview.chromium.org/10870068/diff/1/chrome/browser/ui/webui/extens...
chrome/browser/ui/webui/extensions/command_handler.cc:49: registrar_.Add(this,
chrome::NOTIFICATION_EXTENSION_UNINSTALLED,
Changed to load/unload.

On 2012/08/24 16:00:40, Yoyo Zhou wrote:
> You wrote install/uninstall in the CL description, but this is load/uninstall.
> It should be either load/unload or install/uninstall.

http://codereview.chromium.org/10870068/diff/1/chrome/browser/ui/webui/extens...
File chrome/browser/ui/webui/extensions/command_handler.h (right):

http://codereview.chromium.org/10870068/diff/1/chrome/browser/ui/webui/extens...
chrome/browser/ui/webui/extensions/command_handler.h:42: virtual void
Observe(int type, const content::NotificationSource& source,
There was a discussion about this a few years back and I believe the decision
that was reached was to not change the visibility of functions when overloading.
I've been following that ever since.

On 2012/08/24 16:00:40, Yoyo Zhou wrote:
> On 2012/08/24 15:24:26, James Hawkins wrote:
> > nit: Method declarations must have one parameter per-line if they don't all
> fit
> > one one line.
> 
> Also, this can be private.

http://codereview.chromium.org/10870068/diff/1/chrome/browser/ui/webui/extens...
chrome/browser/ui/webui/extensions/command_handler.h:66: // Used to observe
notifications.
Removed. 

Also, added Profile since trying to decipher the profile from web_contents was
crashing in tests (see previous try run if you are interested). :)

[Yoyo Zhou, 2012-08-27 15:12:29]

LGTM