Make sure the Commands list correctly reflects the status of extensions right after install/uninsta…

chrome/browser/ui/webui/extensions/command_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_EXTENSIONS_COMMAND_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_EXTENSIONS_COMMAND_HANDLER_H_
 
 #include "base/compiler_specific.h"
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/web_ui_message_handler.h"
 
 namespace base {
 class DictionaryValue;
 class ListValue;
 }
 
 namespace extensions {
 class Command;
 class CommandService;
 }
 
 class Extension;
 
 namespace extensions {
 
 // The handler page for the Extension Commands UI overlay.
-class CommandHandler : public content::WebUIMessageHandler {
+class CommandHandler : public content::WebUIMessageHandler,
+                       public content::NotificationObserver {
  public:
   CommandHandler();
   virtual ~CommandHandler();
 
   // Fetches the localized values for the page and deposits them into
   // |localized_strings|.
   void GetLocalizedValues(base::DictionaryValue* localized_strings);
 
   // WebUIMessageHandler implementation.
   virtual void RegisterMessages() OVERRIDE;
 
+  // NotificationObserver implementation.
+  virtual void Observe(int type, const content::NotificationSource& source,

[James Hawkins, 2012/08/24 15:24:26]

nit: Method declarations must have one parameter per-line if they don't all fit
one one line.

[Yoyo Zhou, 2012/08/24 16:00:40]

Also, this can be private.

[Finnur, 2012/08/27 11:46:02]

There was a discussion about this a few years back and I believe the decision
that was reached was to not change the visibility of functions when overloading.
I've been following that ever since.

On 2012/08/24 16:00:40, Yoyo Zhou wrote:

+                       const content::NotificationDetails& details) OVERRIDE;
+
  private:
    // Update the list of extension commands in the config UI.
   void UpdateCommandDataOnPage();
 
   // Handles requests from javascript to fetch the extensions data, including
   // the commands it contains.
   // Replies back through: ExtensionCommandsOverlay.returnExtensionsData.
   void HandleRequestExtensionsData(const base::ListValue* args);
 
   // Handles requests from javascript to set a particular keyboard shortcut
   // for a given extension command.
   void HandleSetExtensionCommandShortcut(const base::ListValue* args);
 
   // Handles requests from javascript to temporarily disable general Chrome
   // shortcut handling while the web page is capturing which shortcut to use.
   void HandleSetShortcutHandlingSuspended(const base::ListValue* args);
 
   // Fetches all known commands, active and inactive and returns them through
   // |commands|.
   void GetAllCommands(base::DictionaryValue* commands);
 
+  // Used to observe notifications.

[Yoyo Zhou, 2012/08/24 16:00:40]

nit: IMHO, unnecessary comment.

[Finnur, 2012/08/27 11:46:02]

Removed. 

Also, added Profile since trying to decipher the profile from web_contents was
crashing in tests (see previous try run if you are interested). :)

+  content::NotificationRegistrar registrar_;
+
   DISALLOW_COPY_AND_ASSIGN(CommandHandler);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_UI_WEBUI_EXTENSIONS_COMMAND_HANDLER_H_