Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: webkit/appcache/appcache_url_request_job_unittest.cc

Issue 10870060: Removed calls to URLRequest::URLRequest in favor of URLRequestContext::CreateRequest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/appcache/appcache_url_request_job_unittest.cc
diff --git a/webkit/appcache/appcache_url_request_job_unittest.cc b/webkit/appcache/appcache_url_request_job_unittest.cc
index 9fa8ded9e55ab593ce8b050209d52201d283d9f5..799367a40ef967129ab597675bcdb345062b4c22 100644
--- a/webkit/appcache/appcache_url_request_job_unittest.cc
+++ b/webkit/appcache/appcache_url_request_job_unittest.cc
@@ -443,10 +443,8 @@ class AppCacheURLRequestJobTest : public testing::Test {
base::Unretained(this)));
AppCacheStorage* storage = service_->storage();
- request_.reset(
- new net::URLRequest(GURL("http://blah/"),
- url_request_delegate_.get(),
- &empty_context_));
+ request_.reset( empty_context_.CreateRequest(
mmenke 2012/08/24 14:40:11 nit: Remove space after request_.reset(
shalev 2012/08/24 19:07:06 Done.
+ GURL("http://blah/"), url_request_delegate_.get()));
// Setup to create an AppCacheURLRequestJob with orders to deliver
// a network response.
@@ -479,10 +477,8 @@ class AppCacheURLRequestJobTest : public testing::Test {
base::Unretained(this)));
AppCacheStorage* storage = service_->storage();
- request_.reset(
- new net::URLRequest(GURL("http://blah/"),
- url_request_delegate_.get(),
- &empty_context_));
+ request_.reset(empty_context_.CreateRequest(GURL(
+ "http://blah/"), url_request_delegate_.get()));
// Setup to create an AppCacheURLRequestJob with orders to deliver
// a network response.
@@ -530,10 +526,8 @@ class AppCacheURLRequestJobTest : public testing::Test {
void RequestAppCachedResource(bool start_after_delivery_orders) {
AppCacheStorage* storage = service_->storage();
- request_.reset(
- new net::URLRequest(GURL("http://blah/"),
- url_request_delegate_.get(),
- &empty_context_));
+ request_.reset(empty_context_.CreateRequest(
+ GURL("http://blah/"), url_request_delegate_.get()));
// Setup to create an AppCacheURLRequestJob with orders to deliver
// a network response.
@@ -644,10 +638,8 @@ class AppCacheURLRequestJobTest : public testing::Test {
void MakeRangeRequest() {
AppCacheStorage* storage = service_->storage();
- request_.reset(
- new net::URLRequest(GURL("http://blah/"),
- url_request_delegate_.get(),
- &empty_context_));
+ request_.reset(empty_context_.CreateRequest(
+ GURL("http://blah/"), url_request_delegate_.get()));
// Request a range, the 3 middle chars out of 'Hello'
net::HttpRequestHeaders extra_headers;

Powered by Google App Engine
This is Rietveld 408576698