Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 10870029: Remove legacy migration code that coupled history and bookmarks. (Closed)

Created:
8 years, 4 months ago by erikwright (departed)
Modified:
8 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, browser-components-watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Remove legacy migration code that coupled history and bookmarks. R=sky BUG=144050 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154058

Patch Set 1 #

Patch Set 2 : Add a unit test. #

Patch Set 3 : Remove obsoleted unit test. #

Total comments: 2

Patch Set 4 : nits. #

Patch Set 5 : Sync. #

Patch Set 6 : Update Android code. #

Patch Set 7 : More android fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -1331 lines) Patch
M chrome/browser/bookmarks/bookmark_model_unittest.cc View 1 2 3 1 chunk +3 lines, -153 lines 0 comments Download
M chrome/browser/history/DEPS View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/android/android_cache_database_unittest.cc View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/history/android/android_provider_backend_unittest.cc View 1 2 3 4 5 20 chunks +18 lines, -21 lines 0 comments Download
M chrome/browser/history/android/android_urls_database_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/android/urls_sql_handler_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/history/android/visit_sql_handler_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/history/expire_history_backend_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_backend.cc View 1 2 3 4 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/history/history_database.h View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/history/history_database.cc View 1 5 chunks +4 lines, -9 lines 0 comments Download
A chrome/browser/history/history_database_unittest.cc View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
D chrome/browser/history/starred_url_database.h View 1 chunk +0 lines, -182 lines 0 comments Download
D chrome/browser/history/starred_url_database.cc View 1 chunk +0 lines, -661 lines 0 comments Download
D chrome/browser/history/starred_url_database_unittest.cc View 1 chunk +0 lines, -283 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
erikwright (departed)
8 years, 4 months ago (2012-08-23 03:23:32 UTC) #1
sky
Please add a test to make sure sure this doesn't bork someones history file.
8 years, 4 months ago (2012-08-23 04:05:55 UTC) #2
erikwright (departed)
PTAL. There is actually lots more code that is now dead as a result of ...
8 years, 4 months ago (2012-08-23 07:13:56 UTC) #3
erikwright (departed)
On 2012/08/23 07:13:56, erikwright wrote: > PTAL. > > There is actually lots more code ...
8 years, 4 months ago (2012-08-23 07:30:23 UTC) #4
erikwright (departed)
Turns out only one was failing due to my changes. The other two fail on ...
8 years, 4 months ago (2012-08-23 07:43:40 UTC) #5
sky
8 years, 4 months ago (2012-08-23 16:04:17 UTC) #6
LGTM

http://codereview.chromium.org/10870029/diff/8003/chrome/browser/history/hist...
File chrome/browser/history/history_database_unittest.cc (right):

http://codereview.chromium.org/10870029/diff/8003/chrome/browser/history/hist...
chrome/browser/history/history_database_unittest.cc:10: #include
"chrome/browser/history/history_database.h"
Tests should follow the order of .cc files, history_database should be the first
include.

http://codereview.chromium.org/10870029/diff/8003/chrome/browser/history/hist...
chrome/browser/history/history_database_unittest.cc:39: int nUrls = 0;
n_urls

Powered by Google App Engine
This is Rietveld 408576698