Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: src/lithium.cc

Issue 10868106: Print reason for disabling optimization. Kill --trace-bailout flag. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Simplified Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/lithium.h ('k') | src/mips/lithium-codegen-mips.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lithium.cc
diff --git a/src/lithium.cc b/src/lithium.cc
index f19ba006fa852fd9b681686d018930b7f662873c..a9cd023dc4823801ddcc68e0da6c2027ecfdf2a2 100644
--- a/src/lithium.cc
+++ b/src/lithium.cc
@@ -390,15 +390,13 @@ Representation LChunk::LookupLiteralRepresentation(
}
-LChunk* LChunk::NewChunk(HGraph* graph) {
+LChunk* LChunk::NewChunk(HGraph* graph, CompilationInfo* info) {
Jakob Kummerow 2012/08/27 14:26:02 Instead of passing in |info|, can't you just use g
Sven Panne 2012/08/28 07:17:08 Good point, I missed that one after refactoring ba
NoHandleAllocation no_handles;
AssertNoAllocation no_gc;
int values = graph->GetMaximumValueID();
if (values > LUnallocated::kMaxVirtualRegisters) {
- if (FLAG_trace_bailout) {
- PrintF("Not enough virtual registers for (values).\n");
- }
+ info->set_bailout_reason("not enough virtual registers for values");
return NULL;
}
LAllocator allocator(values, graph);
@@ -407,9 +405,7 @@ LChunk* LChunk::NewChunk(HGraph* graph) {
if (chunk == NULL) return NULL;
if (!allocator.Allocate(chunk)) {
- if (FLAG_trace_bailout) {
- PrintF("Not enough virtual registers (regalloc).\n");
- }
+ info->set_bailout_reason("not enough virtual registers (regalloc)");
return NULL;
}
« no previous file with comments | « src/lithium.h ('k') | src/mips/lithium-codegen-mips.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698