Print reason for disabling optimization. Kill --trace-bailout flag.

src/lithium.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 372 matching lines @@
   return HConstant::cast(graph_->LookupValue(operand->index()));
 }
 
 
 Representation LChunk::LookupLiteralRepresentation(
     LConstantOperand* operand) const {
   return graph_->LookupValue(operand->index())->representation();
 }
 
 
-LChunk* LChunk::NewChunk(HGraph* graph) {
+LChunk* LChunk::NewChunk(HGraph* graph, CompilationInfo* info) {

[Jakob Kummerow, 2012/08/27 14:26:02]

Instead of passing in |info|, can't you just use graph->info() (as line 403 does
anyway)?

[Sven Panne, 2012/08/28 07:17:08]

Good point, I missed that one after refactoring back and forth. Not needing
another argument is a good sign that CompilationInfo is indeed the right place
to keep the bailout reason. Done.

   NoHandleAllocation no_handles;
   AssertNoAllocation no_gc;
 
   int values = graph->GetMaximumValueID();
   if (values > LUnallocated::kMaxVirtualRegisters) {
-    if (FLAG_trace_bailout) {
-      PrintF("Not enough virtual registers for (values).\n");
-    }
+    info->set_bailout_reason("not enough virtual registers for values");
     return NULL;
   }
   LAllocator allocator(values, graph);
   LChunkBuilder builder(graph->info(), graph, &allocator);
   LChunk* chunk = builder.Build();
   if (chunk == NULL) return NULL;
 
   if (!allocator.Allocate(chunk)) {
-    if (FLAG_trace_bailout) {
-      PrintF("Not enough virtual registers (regalloc).\n");
-    }
+    info->set_bailout_reason("not enough virtual registers (regalloc)");
     return NULL;
   }
 
   return chunk;
 }
 
 
 Handle<Code> LChunk::Codegen() {
   MacroAssembler assembler(info()->isolate(), NULL, 0);
   LCodeGen generator(this, &assembler, info());
@@ skipping 10 matching lines @@
         CodeGenerator::MakeCodeEpilogue(&assembler, flags, info());
     generator.FinishCode(code);
     CodeGenerator::PrintCode(code, info());
     return code;
   }
   return Handle<Code>::null();
 }
 
 
 } }  // namespace v8::internal