Issue 10867096: Make HWNDMessageHandler subclass WindowImpl.

Issue 10867096: Make HWNDMessageHandler subclass WindowImpl. (Closed)

Created:
8 years, 3 months ago by Ben Goodger (Google)

Modified:
8 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Make HWNDMessageHandler subclass WindowImpl. This is the last step. All of the dependencies on NWW are now gone. Woohoo. The API is a bit of a wreck after all this moving. I will work on cleaning it up/slimming it down after this. http://crbug.com/142962 R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153840

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+184 lines, -555 lines)			Patch
M	chrome/browser/ui/views/external_tab_container_win.cc	View	1 2	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_frame_win.h	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_frame_win.cc	View	1 2	2 chunks	+35 lines, -34 lines	0 comments	Download
M	ui/views/widget/native_widget_win.h	View	1 2	7 chunks	+10 lines, -199 lines	0 comments	Download
M	ui/views/widget/native_widget_win.cc	View	1 2	9 chunks	+17 lines, -273 lines	0 comments	Download
M	ui/views/win/hwnd_message_handler.h	View	1 2	6 chunks	+110 lines, -19 lines	0 comments	Download
M	ui/views/win/hwnd_message_handler.cc	View	1 2	6 chunks	+9 lines, -19 lines	0 comments	Download
M	ui/views/win/hwnd_message_handler_delegate.h	View	1 2	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/10867096/diff/1/ui/views/win/hwnd_message_handler_delegate.h File ui/views/win/hwnd_message_handler_delegate.h (right): http://codereview.chromium.org/10867096/diff/1/ui/views/win/hwnd_message_handler_delegate.h#newcode196 ui/views/win/hwnd_message_handler_delegate.h:196: // message should not be processed further, returning ...

8 years, 3 months ago (2012-08-27 23:36:04 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/10867096/15016

8 years, 3 months ago (2012-08-29 00:53:02 UTC) #3

Change committed as 153840

Expand Messages | Collapse Messages