Issue 10860012: Add support for metadata annotation syntax (issue 4056)

Issue 10860012: Add support for metadata annotation syntax (issue 4056) (Closed)

Created:
8 years, 4 months ago by Brian Wilkerson

Modified:
8 years, 4 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add support for metadata annotation syntax (issue 4056) Committed: https://code.google.com/p/dart/source/detail?r=10915

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+227 lines, -36 lines)			Patch
M	compiler/java/com/google/dart/compiler/ast/ASTVisitor.java	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	compiler/java/com/google/dart/compiler/ast/DartAnnotation.java	View	1	1 chunk	+52 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartDeclaration.java	View		2 chunks	+7 lines, -6 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartDirective.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartFieldDefinition.java	View		1 chunk	+1 line, -1 line	0 comments	Download
A	compiler/java/com/google/dart/compiler/ast/DartNodeWithMetadata.java	View	1	1 chunk	+32 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/CompletionHooksParserBase.java	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	1	14 chunks	+56 lines, -13 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartParserCommentsHelper.java	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartScanner.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/Token.java	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/ClassElementImplementation.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/MethodElementImplementation.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java	View	1	5 chunks	+60 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

http://codereview.chromium.org/10860012/diff/1/compiler/java/com/google/dart/compiler/ast/DartNodeWithMetadata.java File compiler/java/com/google/dart/compiler/ast/DartNodeWithMetadata.java (right): http://codereview.chromium.org/10860012/diff/1/compiler/java/com/google/dart/compiler/ast/DartNodeWithMetadata.java#newcode14 compiler/java/com/google/dart/compiler/ast/DartNodeWithMetadata.java:14: private NodeList<DartMetadata> metadata = NodeList.create(this); Spec: "Metadata consists of ...

8 years, 4 months ago (2012-08-17 17:37:03 UTC) #2

Brian Wilkerson

PTAL http://codereview.chromium.org/10860012/diff/1/compiler/java/com/google/dart/compiler/ast/DartNodeWithMetadata.java File compiler/java/com/google/dart/compiler/ast/DartNodeWithMetadata.java (right): http://codereview.chromium.org/10860012/diff/1/compiler/java/com/google/dart/compiler/ast/DartNodeWithMetadata.java#newcode14 compiler/java/com/google/dart/compiler/ast/DartNodeWithMetadata.java:14: private NodeList<DartMetadata> metadata = NodeList.create(this); Done

8 years, 4 months ago (2012-08-17 18:28:02 UTC) #3

LGTM

Expand Messages | Collapse Messages