Issue 10857066: Don't use an unretained read callback when calling AudioDecoder::Read().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10857066: Don't use an unretained read callback when calling AudioDecoder::Read(). (Closed)

Created:
8 years, 4 months ago by scherkus (not reviewing)

Modified:
8 years, 4 months ago

Reviewers:
Ami GONE FROM CHROMIUM

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't use an unretained read callback when calling AudioDecoder::Read(). BUG=143440 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152192

Patch Set 2 : #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	media/filters/audio_renderer_impl.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	media/filters/audio_renderer_impl.cc	View		2 chunks	+2 lines, -4 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

PTAL -- candidate fix potential worrisome bit: will we leak memory due to a circular ...

8 years, 4 months ago (2012-08-17 23:01:40 UTC) #1

scherkus (not reviewing)

ran through the gauntlet of valgrind tests and no leaks reported

8 years, 4 months ago (2012-08-17 23:27:37 UTC) #2

Ami GONE FROM CHROMIUM

lgtm http://codereview.chromium.org/10857066/diff/2001/media/filters/audio_renderer_impl.cc File media/filters/audio_renderer_impl.cc (left): http://codereview.chromium.org/10857066/diff/2001/media/filters/audio_renderer_impl.cc#oldcode31 media/filters/audio_renderer_impl.cc:31: base::Unretained(this))) { Unretained(this) for *speed*.

8 years, 4 months ago (2012-08-17 23:46:03 UTC) #3

scherkus (not reviewing)

8 years, 4 months ago (2012-08-17 23:51:54 UTC) #4

http://codereview.chromium.org/10857066/diff/2001/media/filters/audio_rendere...
File media/filters/audio_renderer_impl.cc (left):

http://codereview.chromium.org/10857066/diff/2001/media/filters/audio_rendere...
media/filters/audio_renderer_impl.cc:31: base::Unretained(this))) {
On 2012/08/17 23:46:03, Ami Fischman wrote:
> Unretained(this) for *speed*.

I don't know why I did this. Must have been smoking something.

Expand Messages | Collapse Messages

Issue 10857066: Don't use an unretained read callback when calling AudioDecoder::Read(). (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages