Don't use an unretained read callback when calling AudioDecoder::Read().

media/filters/audio_renderer_impl.cc

Index: media/filters/audio_renderer_impl.cc
diff --git a/media/filters/audio_renderer_impl.cc b/media/filters/audio_renderer_impl.cc
index 384935e28674faab92bdd36aea0f8650faa01c92..948e68833fbf8a68d0588eba50cf0a9b25f3d13c 100644
--- a/media/filters/audio_renderer_impl.cc
+++ b/media/filters/audio_renderer_impl.cc
@@ -26,9 +26,7 @@ AudioRendererImpl::AudioRendererImpl(media::AudioRendererSink* sink)
       stopped_(false),
       sink_(sink),
       is_initialized_(false),
-      underflow_disabled_(false),
-      read_cb_(base::Bind(&AudioRendererImpl::DecodedAudioReady,
-                          base::Unretained(this))) {

[Ami GONE FROM CHROMIUM, 2012/08/17 23:46:03]

Unretained(this) for *speed*.

[scherkus (not reviewing), 2012/08/17 23:51:54]

I don't know why I did this. Must have been smoking something.

+      underflow_disabled_(false) {
 }
 
 void AudioRendererImpl::Play(const base::Closure& callback) {
@@ -292,7 +290,7 @@ void AudioRendererImpl::ScheduleRead_Locked() {
   if (pending_read_ || state_ == kPaused)
     return;
   pending_read_ = true;
-  decoder_->Read(read_cb_);
+  decoder_->Read(base::Bind(&AudioRendererImpl::DecodedAudioReady, this));
 }
 
 void AudioRendererImpl::SetPlaybackRate(float playback_rate) {