Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: chrome/browser/chromeos/gdata/gdata_files.h

Issue 10857063: gdata: Remove logic to detect incompatibility proto (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/gdata/gdata_files.h
diff --git a/chrome/browser/chromeos/gdata/gdata_files.h b/chrome/browser/chromeos/gdata/gdata_files.h
index b99074191a343d9d24829f34351205360b8c7fcb..b8e5191bea2ade1cc1ed4911f5ab789f12f6eb66 100644
--- a/chrome/browser/chromeos/gdata/gdata_files.h
+++ b/chrome/browser/chromeos/gdata/gdata_files.h
@@ -63,7 +63,7 @@ class GDataEntry {
// Converts to/from proto. Only handles the common part (i.e. does not
// touch |file_specific_info|).
- bool FromProto(const GDataEntryProto& proto) WARN_UNUSED_RESULT;
+ void FromProto(const GDataEntryProto& proto);
// TODO(achuith,satorux): Should this be virtual?
achuithb 2012/08/17 22:24:55 I meant to ask you, should ToProto be virtual? I t
satorux1 2012/08/17 22:28:31 probably, but I guess it doesn't have to be as the
void ToProto(GDataEntryProto* proto) const;
@@ -176,7 +176,7 @@ class GDataFile : public GDataEntry {
virtual ~GDataFile();
// Converts to/from proto.
- bool FromProto(const GDataEntryProto& proto) WARN_UNUSED_RESULT;
+ void FromProto(const GDataEntryProto& proto);
void ToProto(GDataEntryProto* proto) const;
DocumentEntry::EntryKind kind() const { return kind_; }
@@ -221,7 +221,7 @@ class GDataDirectory : public GDataEntry {
virtual ~GDataDirectory();
// Converts to/from proto.
- bool FromProto(const GDataDirectoryProto& proto) WARN_UNUSED_RESULT;
+ void FromProto(const GDataDirectoryProto& proto);
void ToProto(GDataDirectoryProto* proto) const;
// Converts the children as a vector of GDataEntryProto.
« no previous file with comments | « chrome/browser/chromeos/gdata/gdata_directory_service_unittest.cc ('k') | chrome/browser/chromeos/gdata/gdata_files.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698