gdata: Remove logic to detect incompatibility proto

chrome/browser/chromeos/gdata/gdata_files.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILES_H_
 #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILES_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 45 matching lines @@
       const PlatformFileInfoProto& proto,
       base::PlatformFileInfo* file_info);
 
   // Converts the platform file info to the proto representation.
   static void ConvertPlatformFileInfoToProto(
       const base::PlatformFileInfo& file_info,
       PlatformFileInfoProto* proto);
 
   // Converts to/from proto. Only handles the common part (i.e. does not
   // touch |file_specific_info|).
-  bool FromProto(const GDataEntryProto& proto) WARN_UNUSED_RESULT;
+  void FromProto(const GDataEntryProto& proto);
   // TODO(achuith,satorux): Should this be virtual?

[achuithb, 2012/08/17 22:24:55]

I meant to ask you, should ToProto be virtual? I think it should be.

[satorux1, 2012/08/17 22:28:31]

probably, but I guess it doesn't have to be as the code is working, and the code
will be gone not in the distant future anyway.

   void ToProto(GDataEntryProto* proto) const;
 
   // Similar to ToProto() but this fills in |file_specific_info| and
   // |directory_specific_info| based on the actual type of the entry.
   // Used to obtain full metadata of a file or a directory as
   // GDataEntryProto.
   void ToProtoFull(GDataEntryProto* proto) const;
 
   // Escapes forward slashes from file names with magic unicode character
   // \u2215 pretty much looks the same in UI.
@@ skipping 91 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(GDataEntry);
 };
 
 // Represents "file" in in a GData virtual file system. On gdata feed side,
 // this could be either a regular file or a server side document.
 class GDataFile : public GDataEntry {
  public:
   virtual ~GDataFile();
 
   // Converts to/from proto.
-  bool FromProto(const GDataEntryProto& proto) WARN_UNUSED_RESULT;
+  void FromProto(const GDataEntryProto& proto);
   void ToProto(GDataEntryProto* proto) const;
 
   DocumentEntry::EntryKind kind() const { return kind_; }
   const GURL& thumbnail_url() const { return thumbnail_url_; }
   const GURL& alternate_url() const { return alternate_url_; }
   const std::string& content_mime_type() const { return content_mime_type_; }
   const std::string& file_md5() const { return file_md5_; }
   void set_file_md5(const std::string& file_md5) { file_md5_ = file_md5; }
   const std::string& document_extension() const { return document_extension_; }
   bool is_hosted_document() const { return is_hosted_document_; }
@@ skipping 24 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(GDataFile);
 };
 
 // Represents "directory" in a GData virtual file system. Maps to gdata
 // collection element.
 class GDataDirectory : public GDataEntry {
  public:
   virtual ~GDataDirectory();
 
   // Converts to/from proto.
-  bool FromProto(const GDataDirectoryProto& proto) WARN_UNUSED_RESULT;
+  void FromProto(const GDataDirectoryProto& proto);
   void ToProto(GDataDirectoryProto* proto) const;
 
   // Converts the children as a vector of GDataEntryProto.
   scoped_ptr<GDataEntryProtoVector> ToProtoVector() const;
 
  private:
   // TODO(satorux): Remove the friend statements. crbug.com/139649
   friend class GDataDirectoryService;
   friend class GDataWapiFeedProcessor;
 
@@ skipping 45 matching lines @@
   // Collection of children.
   GDataFileCollection child_files_;
   GDataDirectoryCollection child_directories_;
 
   DISALLOW_COPY_AND_ASSIGN(GDataDirectory);
 };
 
 }  // namespace gdata
 
 #endif  // CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILES_H_