Chromium Code Reviews| Index: chrome/browser/chromeos/gdata/gdata_files.h |
| diff --git a/chrome/browser/chromeos/gdata/gdata_files.h b/chrome/browser/chromeos/gdata/gdata_files.h |
| index b99074191a343d9d24829f34351205360b8c7fcb..b8e5191bea2ade1cc1ed4911f5ab789f12f6eb66 100644 |
| --- a/chrome/browser/chromeos/gdata/gdata_files.h |
| +++ b/chrome/browser/chromeos/gdata/gdata_files.h |
| @@ -63,7 +63,7 @@ class GDataEntry { |
| // Converts to/from proto. Only handles the common part (i.e. does not |
| // touch |file_specific_info|). |
| - bool FromProto(const GDataEntryProto& proto) WARN_UNUSED_RESULT; |
| + void FromProto(const GDataEntryProto& proto); |
| // TODO(achuith,satorux): Should this be virtual? |
|
achuithb
2012/08/17 22:24:55
I meant to ask you, should ToProto be virtual? I t
satorux1
2012/08/17 22:28:31
probably, but I guess it doesn't have to be as the
|
| void ToProto(GDataEntryProto* proto) const; |
| @@ -176,7 +176,7 @@ class GDataFile : public GDataEntry { |
| virtual ~GDataFile(); |
| // Converts to/from proto. |
| - bool FromProto(const GDataEntryProto& proto) WARN_UNUSED_RESULT; |
| + void FromProto(const GDataEntryProto& proto); |
| void ToProto(GDataEntryProto* proto) const; |
| DocumentEntry::EntryKind kind() const { return kind_; } |
| @@ -221,7 +221,7 @@ class GDataDirectory : public GDataEntry { |
| virtual ~GDataDirectory(); |
| // Converts to/from proto. |
| - bool FromProto(const GDataDirectoryProto& proto) WARN_UNUSED_RESULT; |
| + void FromProto(const GDataDirectoryProto& proto); |
| void ToProto(GDataDirectoryProto* proto) const; |
| // Converts the children as a vector of GDataEntryProto. |