Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 10855068: Add more test to DisplayControllerTest. (Closed)

Created:
8 years, 4 months ago by Yusuke Sato
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Add more test to DisplayControllerTest. BUG=None TEST=the new test passed on try Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150884

Patch Set 1 : review #

Total comments: 2

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M ash/display/display_controller_unittest.cc View 1 2 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yusuke Sato
Let me add one more test for the function.
8 years, 4 months ago (2012-08-09 15:33:37 UTC) #1
sky
LGTM http://codereview.chromium.org/10855068/diff/5001/ash/display/display_controller_unittest.cc File ash/display/display_controller_unittest.cc (right): http://codereview.chromium.org/10855068/diff/5001/ash/display/display_controller_unittest.cc#newcode166 ash/display/display_controller_unittest.cc:166: TEST_F(DisplayControllerTest, WarpMouseDifferentSizeDisplays) { Add a brief description to ...
8 years, 4 months ago (2012-08-09 16:24:05 UTC) #2
Yusuke Sato
http://codereview.chromium.org/10855068/diff/5001/ash/display/display_controller_unittest.cc File ash/display/display_controller_unittest.cc (right): http://codereview.chromium.org/10855068/diff/5001/ash/display/display_controller_unittest.cc#newcode166 ash/display/display_controller_unittest.cc:166: TEST_F(DisplayControllerTest, WarpMouseDifferentSizeDisplays) { On 2012/08/09 16:24:05, sky wrote: > ...
8 years, 4 months ago (2012-08-09 18:13:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10855068/5003
8 years, 4 months ago (2012-08-09 18:16:17 UTC) #4
commit-bot: I haz the power
Try job failure for 10855068-5003 (retry) (retry) on mac_rel for step "browser_tests". It's a second ...
8 years, 4 months ago (2012-08-09 19:50:39 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 19:59:43 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698