Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: media/base/pipeline.cc

Issue 10855051: Use enum instead of string in MessageLoopFactory::GetMessageLoop* (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Resolve comments. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/pipeline.cc
diff --git a/media/base/pipeline.cc b/media/base/pipeline.cc
index 94817aa9ed1033ce8515a05c5b15dd8b9d9fe4b6..9f6df8c8ee8af9ec9d074cc41221229c5e2d4b0e 100644
--- a/media/base/pipeline.cc
+++ b/media/base/pipeline.cc
@@ -66,8 +66,9 @@ struct Pipeline::PipelineInitState {
scoped_refptr<VideoDecoder> video_decoder;
};
-Pipeline::Pipeline(MessageLoop* message_loop, MediaLog* media_log)
- : message_loop_(message_loop->message_loop_proxy()),
+Pipeline::Pipeline(const scoped_refptr<base::MessageLoopProxy>& message_loop,
+ MediaLog* media_log)
+ : message_loop_(message_loop),
media_log_(media_log),
running_(false),
seek_pending_(false),
@@ -546,8 +547,8 @@ void Pipeline::OnFilterInitialize(PipelineStatus status) {
// makes it look like a host()->SetError() call followed by a call to
// OnFilterStateTransition() when errors occur.
//
-// TODO: Revisit this code when SetError() is removed from FilterHost and
-// all the Closures are converted to PipelineStatusCB.
+// TODO(scherkus): Revisit this code when SetError() is removed from FilterHost
+// and all the Closures are converted to PipelineStatusCB.
scherkus (not reviewing) 2012/08/10 17:00:09 don't indent -- people with long ldaps get cheated
xhwang 2012/08/10 19:33:33 Done.
void Pipeline::OnFilterStateTransition(PipelineStatus status) {
if (status != PIPELINE_OK)
SetError(status);

Powered by Google App Engine
This is Rietveld 408576698