Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Unified Diff: media/filters/ffmpeg_audio_decoder.h

Issue 10855051: Use enum instead of string in MessageLoopFactory::GetMessageLoop* (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Resolve comments. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/ffmpeg_audio_decoder.h
diff --git a/media/filters/ffmpeg_audio_decoder.h b/media/filters/ffmpeg_audio_decoder.h
index c63edaed5ef76a1bccb8cf14a67cdd512bad893f..2676d7c94b342b6113e3204a26cd714060382354 100644
--- a/media/filters/ffmpeg_audio_decoder.h
+++ b/media/filters/ffmpeg_audio_decoder.h
@@ -8,13 +8,16 @@
#include <list>
#include "base/callback.h"
-#include "base/message_loop.h"
#include "media/base/audio_decoder.h"
#include "media/base/demuxer_stream.h"
struct AVCodecContext;
struct AVFrame;
+namespace base {
+class MessageLoopProxy;
+}
+
namespace media {
class DataBuffer;
@@ -22,7 +25,8 @@ class DecoderBuffer;
class MEDIA_EXPORT FFmpegAudioDecoder : public AudioDecoder {
public:
- FFmpegAudioDecoder(const base::Callback<MessageLoop*()>& message_loop_cb);
+ typedef base::Callback<scoped_refptr<base::MessageLoopProxy>()> MessageLoopCB;
Ami GONE FROM CHROMIUM 2012/08/10 04:38:06 s/MessageLoopCB/MessageLoopFactoryCB/
xhwang 2012/08/10 19:33:33 Done.
+ explicit FFmpegAudioDecoder(const MessageLoopCB& message_loop_cb);
// AudioDecoder implementation.
virtual void Initialize(const scoped_refptr<DemuxerStream>& stream,
@@ -58,8 +62,9 @@ class MEDIA_EXPORT FFmpegAudioDecoder : public AudioDecoder {
base::TimeDelta GetNextOutputTimestamp() const;
// This is !is_null() iff Initialize() hasn't been called.
- base::Callback<MessageLoop*()> message_loop_factory_cb_;
- MessageLoop* message_loop_;
+ MessageLoopCB message_loop_factory_cb_;
+
+ scoped_refptr<base::MessageLoopProxy> message_loop_;
scoped_refptr<DemuxerStream> demuxer_stream_;
StatisticsCB statistics_cb_;

Powered by Google App Engine
This is Rietveld 408576698