Store variable counts in the flow graph builder.

Store variable counts in the flow graph builder.

Store the constant counts of copied parameters, non-copied parameters, and
(non-parameter) stack locals in the flow graph builder.  This saves passing
them around to flow graph member functions.

Change usage of "fixed parameter" to "non-copied parameter" because it is
different than what fixed parameter means in other parts of the system.

R=fschneider@google.com,zerny@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=10289

[Kevin Millikin (Google), 2012-08-06 14:00:45]

This is redundant with the values in the ParsedFunction and Function, but it
should be simpler that computing it locally and passing it around.

[Kevin Millikin (Google), 2012-08-06 14:01:14]

http://codereview.chromium.org/10855007/diff/1/runtime/vm/flow_graph_builder.cc
File runtime/vm/flow_graph_builder.cc (right):

http://codereview.chromium.org/10855007/diff/1/runtime/vm/flow_graph_builder....
runtime/vm/flow_graph_builder.cc:2544: // TODO(fschneider): Store counts in the
FlowGraphBuilder instead of
I'll remove the TODO :)

[Florian Schneider, 2012-08-06 14:13:16]

lgtm

http://codereview.chromium.org/10855007/diff/1/runtime/vm/flow_graph_builder.cc
File runtime/vm/flow_graph_builder.cc (right):

http://codereview.chromium.org/10855007/diff/1/runtime/vm/flow_graph_builder....
runtime/vm/flow_graph_builder.cc:2620: intptr_t index =
comp->AsLoadLocal()->local().BitIndexIn(
Not sure if it's possible, but I'd break line after =

http://codereview.chromium.org/10855007/diff/1/runtime/vm/flow_graph_builder....
runtime/vm/flow_graph_builder.cc:2628: intptr_t index =
comp->AsStoreLocal()->local().BitIndexIn(
Not sure if it's possible, but I'd break line after =

[zerny-google, 2012-08-06 14:34:13]

lgtm

On 2012/08/06 14:13:16, Florian Schneider wrote:
> lgtm
> 
>
http://codereview.chromium.org/10855007/diff/1/runtime/vm/flow_graph_builder.cc
> File runtime/vm/flow_graph_builder.cc (right):
> 
>
http://codereview.chromium.org/10855007/diff/1/runtime/vm/flow_graph_builder....
> runtime/vm/flow_graph_builder.cc:2620: intptr_t index =
> comp->AsLoadLocal()->local().BitIndexIn(
> Not sure if it's possible, but I'd break line after =
> 
>
http://codereview.chromium.org/10855007/diff/1/runtime/vm/flow_graph_builder....
> runtime/vm/flow_graph_builder.cc:2628: intptr_t index =
> comp->AsStoreLocal()->local().BitIndexIn(
> Not sure if it's possible, but I'd break line after =