chrome/installer/util/duplicate_tree_detector.cc - Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/duplicate_tree_detector.cc

Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks, (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/setup/uninstall.cc ('K') | « chrome/installer/setup/uninstall.cc ('k') | chrome/test/webdriver/webdriver_util.cc » ('j') | chrome/tools/profiles/generate_profile.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/util/duplicate_tree_detector.cc

diff --git a/chrome/installer/util/duplicate_tree_detector.cc b/chrome/installer/util/duplicate_tree_detector.cc

index cc80f0c843aa83eec90c7e8b380986d5ddca2b7c..d52eb93041a28f292ff59e8eaa621c1b7070bc10 100644

--- a/chrome/installer/util/duplicate_tree_detector.cc

+++ b/chrome/installer/util/duplicate_tree_detector.cc

@@ -31,8 +31,7 @@ bool IsIdenticalFileHierarchy(const FilePath& src_path,

FileEnumerator path_enum(

src_path,

false, // Not recursive

- static_cast<FileEnumerator::FileType>(

- FileEnumerator::FILES | FileEnumerator::DIRECTORIES));

+ (FileEnumerator::FILES | FileEnumerator::DIRECTORIES));

jar (doing other things) 2012/08/06 18:27:02 nit: remove extra paren around arg 3, and push lin

Haruki Sato 2012/08/06 23:22:18 Done.

for (FilePath path = path_enum.Next(); is_identical && !path.empty();

path = path_enum.Next()) {

is_identical =

« chrome/installer/setup/uninstall.cc ('K') | « chrome/installer/setup/uninstall.cc ('k') | chrome/test/webdriver/webdriver_util.cc » ('j') | chrome/tools/profiles/generate_profile.cc » ('J')