chrome/installer/setup/uninstall.cc - Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks, (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/uninstall.cc

diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc

index 3424de270afc6206e2d10a19fc5201b4de3515f8..4e606bb6159c596ee3489c11fb26cda6c6c03dc8 100644

--- a/chrome/installer/setup/uninstall.cc

+++ b/chrome/installer/setup/uninstall.cc

@@ -469,8 +469,7 @@ DeleteResult DeleteChromeFilesAndFolders(const InstallerState& installer_state,

FileEnumerator file_enumerator(

target_path,

false,

- static_cast<FileEnumerator::FileType>(FileEnumerator::FILES |

- FileEnumerator::DIRECTORIES));

+ (FileEnumerator::FILES | FileEnumerator::DIRECTORIES));

jar (doing other things) 2012/08/06 18:27:02 nit: remove parens around arg 3; Consider pushing

Haruki Sato 2012/08/06 23:22:18 Done. Thanks.

while (true) {

FilePath to_delete(file_enumerator.Next());

if (to_delete.empty())

« chrome/common/zip.cc ('K') | « chrome/common/zip_unittest.cc ('k') | chrome/installer/util/duplicate_tree_detector.cc » ('j') | chrome/installer/util/duplicate_tree_detector.cc » ('J')