chrome/browser/chromeos/gdata/gdata_cache.cc - Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/gdata/gdata_cache.cc

Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks, (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/file_util_unittest.cc ('K') | « base/test/test_file_util_posix.cc ('k') | chrome/browser/chromeos/gdata/gdata_cache_metadata.cc » ('j') | chrome/browser/chromeos/gdata/gdata_cache_metadata.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/gdata/gdata_cache.cc

diff --git a/chrome/browser/chromeos/gdata/gdata_cache.cc b/chrome/browser/chromeos/gdata/gdata_cache.cc

index 6b2efb326d501475a755d3341c40fe6c673eae06..ba23149ed122495bd5ddbcaf0f0b17dd455a16ab 100644

--- a/chrome/browser/chromeos/gdata/gdata_cache.cc

+++ b/chrome/browser/chromeos/gdata/gdata_cache.cc

@@ -182,9 +182,8 @@ void DeleteFilesSelectively(const FilePath& path_to_delete_pattern,

file_util::FileEnumerator enumerator(

path_to_delete_pattern.DirName(),

false, // not recursive

- static_cast<file_util::FileEnumerator::FileType>(

- file_util::FileEnumerator::FILES |

- file_util::FileEnumerator::SHOW_SYM_LINKS),

+ (file_util::FileEnumerator::FILES |

+ file_util::FileEnumerator::SHOW_SYM_LINKS),

jar (doing other things) 2012/08/06 18:27:02 nit: IMO, no need for paren around arg.

Haruki Sato 2012/08/06 23:22:18 I think it helps when the expression occupies mult

jar (doing other things) 2012/08/07 01:47:43 These examples are IMO borderline... but they prov

path_to_delete_pattern.BaseName().value());

for (FilePath current = enumerator.Next(); !current.empty();

current = enumerator.Next()) {