Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks,

chrome/browser/chromeos/gdata/gdata_cache.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/gdata/gdata_cache.h"
 
 #include <vector>
 
 #include "base/chromeos/chromeos_version.h"
 #include "base/file_util.h"
@@ skipping 164 matching lines @@
 // deleted.
 void DeleteFilesSelectively(const FilePath& path_to_delete_pattern,
                             const FilePath& path_to_keep) {
   // Enumerate all files in directory of |path_to_delete_pattern| that match
   // base name of |path_to_delete_pattern|.
   // If a file is not |path_to_keep|, delete it.
   bool success = true;
   file_util::FileEnumerator enumerator(
       path_to_delete_pattern.DirName(),
       false,  // not recursive
-      static_cast<file_util::FileEnumerator::FileType>(
-          file_util::FileEnumerator::FILES |
-          file_util::FileEnumerator::SHOW_SYM_LINKS),
+      (file_util::FileEnumerator::FILES |
+       file_util::FileEnumerator::SHOW_SYM_LINKS),

[jar (doing other things), 2012/08/06 18:27:02]

nit: IMO, no need for paren around arg.

[Haruki Sato, 2012/08/06 23:22:18]

I think it helps when the expression occupies multiple lines.
Do you prefer to remove these parentheses? 

[jar (doing other things), 2012/08/07 01:47:43]

These examples are IMO borderline... but they provide a nice wrapping point....
so you can keep 'em IMO.

On 2012/08/06 23:22:18, Haruki Sato wrote:

       path_to_delete_pattern.BaseName().value());
   for (FilePath current = enumerator.Next(); !current.empty();
        current = enumerator.Next()) {
     // If |path_to_keep| is not empty and same as current, don't delete it.
     if (!path_to_keep.empty() && current == path_to_keep)
       continue;
 
     success = file_util::Delete(current, false);
     if (!success)
       DVLOG(1) << "Error deleting " << current.value();
@@ skipping 1375 matching lines @@
     const GDataCacheEntry& cache_entry) {
   return cache_entry.is_persistent() ? CACHE_TYPE_PERSISTENT : CACHE_TYPE_TMP;
 }
 
 void SetFreeDiskSpaceGetterForTesting(FreeDiskSpaceGetterInterface* getter) {
   delete global_free_disk_getter_for_testing;  // Safe to delete NULL;
   global_free_disk_getter_for_testing = getter;
 }
 
 }  // namespace gdata