Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: base/file_util.h

Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks, (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Addressed the comments about constant names. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/file_util.cc » ('j') | webkit/fileapi/file_system_database_test_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/file_util.h
diff --git a/base/file_util.h b/base/file_util.h
index fb6f6244a06cef12eb10af0d71d8ad000d000ab4..e2aa899005add391eafa0024f6df81eb5db13fd7 100644
--- a/base/file_util.h
+++ b/base/file_util.h
@@ -517,8 +517,8 @@ class BASE_EXPORT FileEnumerator {
// files in one directory will be returned before any files in a
// subdirectory.
//
- // |file_type| specifies whether the enumerator should match files,
- // directories, or both.
+ // |file_type|, a bit mask of |FileType|, specifies whether the enumerator
kinuko 2012/08/07 05:23:11 nit: you won't need '|' for FileType
Haruki Sato 2012/08/07 13:34:25 Done. Thanks!
+ // should match files, directories, or both.
//
// |pattern| is an optional pattern for which files to match. This
// works like shell globbing. For example, "*.txt" or "Foo???.doc".
@@ -531,10 +531,10 @@ class BASE_EXPORT FileEnumerator {
// TODO(erikkay): Fix the pattern matching to work at all levels.
FileEnumerator(const FilePath& root_path,
bool recursive,
- FileType file_type);
+ int file_type);
FileEnumerator(const FilePath& root_path,
bool recursive,
- FileType file_type,
+ int file_type,
const FilePath::StringType& pattern);
~FileEnumerator();
@@ -581,7 +581,7 @@ class BASE_EXPORT FileEnumerator {
FilePath root_path_;
bool recursive_;
- FileType file_type_;
+ int file_type_;
FilePath::StringType pattern_; // Empty when we want to find everything.
// A stack that keeps track of which subdirectories we still need to
« no previous file with comments | « no previous file | base/file_util.cc » ('j') | webkit/fileapi/file_system_database_test_helper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698