webkit/fileapi/file_system_database_test_helper.cc - Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/fileapi/file_system_database_test_helper.cc

Issue 10855002: Change the type of file_type parameter to int, as the parameter actually takes or-ed bitmasks, (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Addressed the comments about constant names. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/fileapi/file_system_database_test_helper.cc

diff --git a/webkit/fileapi/file_system_database_test_helper.cc b/webkit/fileapi/file_system_database_test_helper.cc

index 28951d08bd35072229dfdcfb600c4997f6cfd0a9..c7526c3cbc3d4bc7d57a6d061d1efeb97ed45d68 100644

--- a/webkit/fileapi/file_system_database_test_helper.cc

+++ b/webkit/fileapi/file_system_database_test_helper.cc

@@ -19,11 +19,9 @@ void CorruptDatabase(const FilePath& db_path,

leveldb::FileType type,

ptrdiff_t offset,

size_t size) {

- file_util::FileEnumerator file_enum(

- db_path, false /* recursive */,

- static_cast<file_util::FileEnumerator::FileType>(

- file_util::FileEnumerator::DIRECTORIES |

- file_util::FileEnumerator::FILES));

+ file_util::FileEnumerator file_enum(db_path, false /* not recursive */,

+ (file_util::FileEnumerator::DIRECTORIES |

+ file_util::FileEnumerator::FILES));

kinuko 2012/08/07 05:23:11 nit: parens not needed? (here and elsewhere. I o

Haruki Sato 2012/08/07 13:34:25 Done.

FilePath file_path;

FilePath picked_file_path;

uint64 picked_file_number = kuint64max;

« base/file_util.h ('K') | « net/disk_cache/cache_util_posix.cc ('k') | webkit/fileapi/file_system_directory_database.cc » ('j') | webkit/fileapi/file_system_directory_database.cc » ('J')