media/tools/player_x11/player_x11.cc - Issue 10854151: Allow transitioning to HAVE_METADATA before pipeline initialization completes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/tools/player_x11/player_x11.cc

Issue 10854151: Allow transitioning to HAVE_METADATA before pipeline initialization completes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address CR comments and fix tests. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/tools/player_x11/player_x11.cc

diff --git a/media/tools/player_x11/player_x11.cc b/media/tools/player_x11/player_x11.cc

index 8970b18042cf92f3b9ff4851ecfec08f5383519f..48232422a7a675cb1e1764af22bc2836fda069a7 100644

--- a/media/tools/player_x11/player_x11.cc

+++ b/media/tools/player_x11/player_x11.cc

@@ -140,7 +140,7 @@ bool InitPipeline(const scoped_refptr<base::MessageLoopProxy>& message_loop,

media::PipelineStatusNotification note;

(*pipeline)->Start(

collection.Pass(), media::PipelineStatusCB(), media::PipelineStatusCB(),

- note.Callback());

+ note.Callback(), media::Pipeline::ReadyStateCB());

// Wait until the pipeline is fully initialized.

note.Wait();

« media/base/pipeline.h ('K') | « media/tools/player_wtl/movie.cc ('k') | webkit/media/webmediaplayer_impl.h » ('j') | webkit/media/webmediaplayer_impl.h » ('J')